From: Keith Busch <kbusch@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Paulo Alcantara <pc@manguebit.org>,
netfs@lists.linux.dev, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] block: Fix start and length check added to iov_iter_extract_bvecs()
Date: Fri, 4 Sep 2026 12:37:16 -0600 [thread overview]
Message-ID: <apsP3Hvlw-fpd6uF@kbusch-mbp> (raw)
In-Reply-To: <350212.1788514937@warthog.procyon.org.uk>
On Fri, Sep 04, 2026 at 10:42:17AM +0100, David Howells wrote:
> Christoph Hellwig <hch@lst.de> wrote:
>
> > Should this grow a comment explaining why for non-iov/kvec/ubuf
> > we check the alignment of every sector instead of just the
> > start alignment?
>
> There should possibly be a comment explaining the need for an address
> alignment at all. Is it mandatory for all devices? Or are we being a bit
> over restrictive? I don't think NICs capable of RDMA are so restricted, for
> example.
If a block device behind an RDMA NIC really wants to DMA a single byte
at a time, we can't describe that capability today. That would require a
0 mask, which is currently treated as "unset" and overridden with a
default 512b mask.
next prev parent reply other threads:[~2026-09-04 18:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:18 [PATCH] block: Fix start and length check added to iov_iter_extract_bvecs() David Howells
2026-08-26 18:34 ` Keith Busch
2026-08-26 19:24 ` David Howells
2026-08-26 19:47 ` Keith Busch
2026-08-26 20:23 ` David Howells
2026-08-26 19:49 ` David Howells
2026-08-26 20:02 ` Keith Busch
2026-08-26 20:46 ` [PATCH v2] " David Howells
2026-08-26 20:52 ` Keith Busch
2026-08-26 20:54 ` David Howells
2026-09-02 11:27 ` Christoph Hellwig
2026-09-04 9:42 ` David Howells
2026-09-04 18:37 ` Keith Busch [this message]
2026-09-05 16:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apsP3Hvlw-fpd6uF@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=dhowells@redhat.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox