From: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 0/3] fb fixes for gk20a/gm20b
Date: Thu, 27 Oct 2016 16:55:51 +0900 [thread overview]
Message-ID: <20161027075554.18791-1-acourbot@nvidia.com> (raw)
After observing random crashes on Tegra devices when patch "fb/gf100: defer DMA
mapping of scratch page to oneinit() hook" was applied, I noticed that moving
the 100c10 page allocation to the oneinit() hook resulted in that page being
now allocated for Tegra as well, and accesses be made to members of gf100_fb
which were not accessible because gk20a_fb_new() called nvkm_fb_new_() directly.
This is fixed by patch 1, but looking at this code made me realize we may just
as well use the regular FB functions for gk20a/gm20b (without the ablity to
allocate VRAM of course), so patches 2 and 3 do that.
Alexandre Courbot (3):
fb/gk20a: fix constructor call
fb/gk20a: use regular gf100's functions
fb: add gm20b device
drm/nouveau/include/nvkm/subdev/fb.h | 1 +
drm/nouveau/nvkm/engine/device/base.c | 2 +-
drm/nouveau/nvkm/subdev/fb/Kbuild | 1 +
drm/nouveau/nvkm/subdev/fb/gf100.h | 4 ++++
drm/nouveau/nvkm/subdev/fb/gk20a.c | 20 ++++++------------
drm/nouveau/nvkm/subdev/fb/gm200.c | 2 +-
drm/nouveau/nvkm/subdev/fb/gm20b.c | 40 +++++++++++++++++++++++++++++++++++
7 files changed, 55 insertions(+), 15 deletions(-)
create mode 100644 drm/nouveau/nvkm/subdev/fb/gm20b.c
--
2.10.0
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next reply other threads:[~2016-10-27 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 7:55 Alexandre Courbot [this message]
[not found] ` <20161027075554.18791-1-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-10-27 7:55 ` [PATCH 1/3] fb/gk20a: fix constructor call Alexandre Courbot
2016-10-27 7:55 ` [PATCH 2/3] fb/gk20a: use regular gf100's functions Alexandre Courbot
[not found] ` <20161027075554.18791-3-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-10-27 11:52 ` Karol Herbst
2016-10-27 7:55 ` [PATCH 3/3] fb: add gm20b device Alexandre Courbot
[not found] ` <20161027075554.18791-4-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-10-27 11:52 ` Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027075554.18791-1-acourbot@nvidia.com \
--to=acourbot-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox