Nouveau Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rhys Kidd <rhyskidd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH xf86-video-nouveau 12/17] config: Add comments for main statements
Date: Mon, 21 Jan 2019 00:52:18 -0500	[thread overview]
Message-ID: <20190121055223.7891-13-rhyskidd@gmail.com> (raw)
In-Reply-To: <20190121055223.7891-1-rhyskidd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
---
 configure.ac | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 7e19da8..41b1217 100644
--- a/configure.ac
+++ b/configure.ac
@@ -20,6 +20,7 @@
 #
 # Process this file with autoconf to produce a configure script
 
+# Initialize Autoconf
 AC_PREREQ([2.60])
 AC_INIT([xf86-video-nouveau],
         [1.0.15],
@@ -35,6 +36,7 @@ AC_CONFIG_HEADERS([config.h])
 AC_CONFIG_MACRO_DIR([m4])
 AC_CONFIG_AUX_DIR(.)
 
+# Initialize Automake
 AM_INIT_AUTOMAKE([dist-bzip2])
 
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
@@ -55,25 +57,27 @@ LT_INIT([disable-static])
 
 AH_TOP([#include "xorg-server.h"])
 
+# Define a configure option for an alternate module directory
 AC_ARG_WITH(xorg-module-dir,
             AS_HELP_STRING([--with-xorg-module-dir=DIR],
                            [Default xorg module directory [[default=$libdir/xorg/modules]]]),
             [moduledir="$withval"],
             [moduledir="$libdir/xorg/modules"])
 
-# Checks for extensions
+# Store the list of server defined optional extensions in REQUIRED_MODULES
 XORG_DRIVER_CHECK_EXT(RANDR, randrproto)
 XORG_DRIVER_CHECK_EXT(RENDER, renderproto)
 XORG_DRIVER_CHECK_EXT(XV, videoproto)
 XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
 XORG_DRIVER_CHECK_EXT(DRI2, [dri2proto >= 2.6])
 
-# Checks for pkg-config packages
+# Checks for libraries
 PKG_CHECK_MODULES(LIBDRM, [libdrm >= 2.4.60])
 PKG_CHECK_MODULES(LIBDRM_NOUVEAU, [libdrm_nouveau >= 2.4.25])
 AC_SUBST(LIBDRM_NOUVEAU_CFLAGS)
 AC_SUBST(LIBDRM_NOUVEAU_LIBS)
 
+# Obtain compiler/linker options for the driver dependencies
 PKG_CHECK_MODULES(XORG, [xorg-server >= 1.8] xproto fontsproto $REQUIRED_MODULES)
 PKG_CHECK_MODULES(XEXT, [xextproto >= 7.0.99.1],
 		  HAVE_XEXTPROTO_71="yes"; AC_DEFINE(HAVE_XEXTPROTO_71, 1, [xextproto 7.1 available]),
@@ -81,7 +85,6 @@ PKG_CHECK_MODULES(XEXT, [xextproto >= 7.0.99.1],
 AM_CONDITIONAL(HAVE_XEXTPROTO_71, [ test "$HAVE_XEXTPROTO_71" = "yes" ])
 sdkdir=$(pkg-config --variable=sdkdir xorg-server)
 
-# Checks for libraries.
 PKG_CHECK_MODULES([PCIACCESS], [pciaccess >= 0.10])
 
 PKG_CHECK_MODULES(LIBUDEV, [libudev], [LIBUDEV=yes], [LIBUDEV=no])
-- 
2.19.1

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2019-01-21  5:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21  5:52 [PATCH xf86-video-nouveau 00/17] autotools configuration cleanups Rhys Kidd
     [not found] ` <20190121055223.7891-1-rhyskidd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 01/17] config: Fix typo in comment Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 02/17] config, nv: Use xorg-macros PACKAGE_VERSION_{MAJOR, MINOR, PATCHLEVEL} Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 03/17] config: Only check for presence of libdrm package once Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 04/17] config: Rely upon list.h as at least xorg-server 1.8 required Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 05/17] config: remove AC_PROG_CC as it overrides AC_PROG_C_C99 Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 06/17] gitignore: Update to mirror modern X.org drivers Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 07/17] config: libtoolize: put macros in AC_CONFIG_MACRO_DIR, 'm4' Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 08/17] config: Use XORG_DEFAULT_OPTIONS which replaces six XORG_* macros Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 09/17] config: remove unrequired AC_HEADER_STDC Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 10/17] config: Utilize util-macros 1.8 for additional man page support Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 11/17] config: Use LT_INIT option instead of AC_DISABLE_STATIC Rhys Kidd
2019-01-21  5:52   ` Rhys Kidd [this message]
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 13/17] config: Remove unrequired AC_SUBST for LIBDRM_NOUVEAU and LIBUDEV Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 14/17] config: remove unused sdkdir=$(pkg-config...) statement Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 15/17] config: Set automake options consistently in one location Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 16/17] config: Complete bug report URL for Xorg DDX nouveau driver Rhys Kidd
2019-01-21  5:52   ` [PATCH xf86-video-nouveau 17/17] config: Suggest upstream to find macros in case they are missing Rhys Kidd
2019-01-22  2:30   ` [PATCH xf86-video-nouveau 00/17] autotools configuration cleanups Ilia Mirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190121055223.7891-13-rhyskidd@gmail.com \
    --to=rhyskidd-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox