Nouveau Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	igt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH i-g-t v3 2/5] lib/igt_core: Add igt_require_fd()
Date: Fri, 17 Apr 2020 17:10:22 -0400	[thread overview]
Message-ID: <20200417211025.109574-3-lyude@redhat.com> (raw)
In-Reply-To: <20200417211025.109574-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

From: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Like igt_assert_fd(), but using igt_require() instead

Changes since v1:
* Fix documentation error in igt_require_fd() - Petri Latvala

Signed-off-by: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 lib/igt_core.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/lib/igt_core.h b/lib/igt_core.h
index 3f69b072..8f68b2dd 100644
--- a/lib/igt_core.h
+++ b/lib/igt_core.h
@@ -1021,6 +1021,18 @@ void igt_describe_f(const char *fmt, ...);
 	else igt_debug("Test requirement passed: %s\n", #expr); \
 } while (0)
 
+/**
+ * igt_require_fd:
+ * @fd: file descriptor
+ *
+ * Skips (sub-) test if the given file descriptor is invalid.
+ *
+ * Like igt_require(), but displays the stringified identifier that was supposed
+ * to contain a valid fd on failure.
+ */
+#define igt_require_fd(fd) \
+	igt_require_f(fd >= 0, "file descriptor " #fd " failed\n");
+
 /**
  * igt_skip_on_f:
  * @expr: condition to test
-- 
2.25.1

  parent reply	other threads:[~2020-04-17 21:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 21:10 [PATCH i-g-t v3 0/5] Add nouveau-crc tests Lyude
     [not found] ` <20200417211025.109574-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-04-17 21:10   ` [PATCH i-g-t v3 1/5] lib/igt_core: Fix igt_assert_fd() documentation Lyude
     [not found]     ` <20200417211025.109574-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-04-20  9:29       ` [igt-dev] " Petri Latvala
2020-04-17 21:10   ` Lyude [this message]
     [not found]     ` <20200417211025.109574-3-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-04-20  9:29       ` [igt-dev] [PATCH i-g-t v3 2/5] lib/igt_core: Add igt_require_fd() Petri Latvala
2020-04-17 21:10   ` [PATCH i-g-t v3 3/5] lib/igt_debugfs: Add igt_debugfs_pipe_dir() Lyude
     [not found]     ` <20200417211025.109574-4-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-08-18 21:01       ` [i-g-t, v3, " Jeremy Cline
2020-04-17 21:10   ` [PATCH i-g-t v3 4/5] lib/igt_kms: Hook up connector dithering prop Lyude
     [not found]     ` <20200417211025.109574-5-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-08-18 21:18       ` [i-g-t, v3, " Jeremy Cline
2020-04-17 21:10   ` [PATCH i-g-t v3 5/5] tests: Add nouveau-crc tests Lyude
     [not found]     ` <20200417211025.109574-6-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-08-18 21:00       ` [PATCH i-g-t v4] " Lyude
     [not found]         ` <20200818210051.28705-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-09-28 21:36           ` [igt-dev] " Jeremy Cline
2020-09-29 16:13             ` Lyude Paul
     [not found]               ` <b5673893f45f4bb72a90ca55d45100391a49c8e8.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-09-29 17:42                 ` Jeremy Cline

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417211025.109574-3-lyude@redhat.com \
    --to=lyude-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=igt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox