From: Daniel Dadap <ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9/egYHeGw8Jk@public.gmane.org,
intel-gfx-PD4FTy7X32lNgt0PjOBp9/egYHeGw8Jk@public.gmane.org,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
alexander.deucher-5C7GfCeVMHo@public.gmane.org,
christian.koenig-5C7GfCeVMHo@public.gmane.org,
david1.zhou-5C7GfCeVMHo@public.gmane.org
Cc: Daniel Dadap <ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 2/4] i915: fall back to ACPI EDID retrieval
Date: Mon, 27 Jul 2020 15:53:55 -0500 [thread overview]
Message-ID: <20200727205357.27839-3-ddadap@nvidia.com> (raw)
In-Reply-To: <20200727205357.27839-1-ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Fall back to retrieving the EDID via the ACPI _DDC method, when present
for notebook internal panels, when EDID retrieval via the standard EDID
paths is unsuccessful.
Signed-off-by: Daniel Dadap <ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
drivers/gpu/drm/i915/display/intel_dp.c | 8 +++++++-
drivers/gpu/drm/i915/display/intel_lvds.c | 4 ++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 804b1d966f66..ff402cef8183 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5657,6 +5657,7 @@ static struct edid *
intel_dp_get_edid(struct intel_dp *intel_dp)
{
struct intel_connector *intel_connector = intel_dp->attached_connector;
+ struct edid *edid;
/* use cached edid if we have one */
if (intel_connector->edid) {
@@ -5666,8 +5667,13 @@ intel_dp_get_edid(struct intel_dp *intel_dp)
return drm_edid_duplicate(intel_connector->edid);
} else
- return drm_get_edid(&intel_connector->base,
+ edid = drm_get_edid(&intel_connector->base,
&intel_dp->aux.ddc);
+
+ if (!edid && intel_dp_is_edp(intel_dp))
+ edid = drm_get_edid_acpi();
+
+ return edid;
}
static void
diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
index 9a067effcfa0..811eea3f5d9f 100644
--- a/drivers/gpu/drm/i915/display/intel_lvds.c
+++ b/drivers/gpu/drm/i915/display/intel_lvds.c
@@ -946,6 +946,10 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
else
edid = drm_get_edid(connector,
intel_gmbus_get_adapter(dev_priv, pin));
+
+ if (!edid)
+ edid = drm_get_edid_acpi();
+
if (edid) {
if (drm_add_edid_modes(connector, edid)) {
drm_connector_update_edid_property(connector,
--
2.18.4
next prev parent reply other threads:[~2020-07-27 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 20:53 [PATCH 0/4] drm: add support for retrieving EDID via ACPI _DDC Daniel Dadap
[not found] ` <20200727205357.27839-1-ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-27 20:53 ` [PATCH 1/4] drm: retrieve EDID via ACPI _DDC method Daniel Dadap
[not found] ` <20200727205357.27839-2-ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-08-08 22:11 ` [Nouveau] " Lukas Wunner
[not found] ` <20200808221114.5rfnys76ozoj62wv-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2020-08-12 22:37 ` Daniel Dadap
[not found] ` <3aa06548-b7b4-6753-7169-88e9b2d80acc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-08-13 3:05 ` [Nouveau] " Alex Deucher
2020-07-27 20:53 ` Daniel Dadap [this message]
2020-07-27 20:53 ` [PATCH 3/4] nouveau: fall back to ACPI EDID retrieval Daniel Dadap
2020-07-27 20:53 ` [PATCH 4/4] radeon: " Daniel Dadap
[not found] ` <20200727205357.27839-5-ddadap-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-28 6:50 ` Christian König
[not found] ` <3c355e4d-b9ff-66b7-e9e3-86027deeba6d-5C7GfCeVMHo@public.gmane.org>
2020-07-28 18:44 ` Daniel Dadap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727205357.27839-3-ddadap@nvidia.com \
--to=ddadap-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=david1.zhou-5C7GfCeVMHo@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9/egYHeGw8Jk@public.gmane.org \
--cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9/egYHeGw8Jk@public.gmane.org \
--cc=jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox