From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: Dave Airlie <airlied@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Ben Skeggs <bskeggs@nvidia.com>, Kees Cook <kees@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Maxime Ripard <mripard@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH v5 0/4] drm/nouveau: GSP runtime PM fixes
Date: Fri, 14 Aug 2026 15:43:47 -0400 [thread overview]
Message-ID: <20260814194542.781955-1-lyude@redhat.com> (raw)
Runtime suspend/resume has been notoriously flakey since we started
using the R570 GSP firmware, and possibly was also flakey for some time
when we introduced GSP support initially.
These fixes get runtime PM to be dramatically more stable then it was
before. Unfortunately even with this patch series, there are still some
remaining issues that need to be fixed. These likely stem from the
currently different code path that we need to take with these fixes in
order to get suspend/resume working.
While we're making progress in understanding what exactly we're doing
differently from OpenRM that makes this the case, it will likely take us
a while before we actually have things working well enough to copy what
OpenRM does. Taking precisely the same path that OpenRM takes however,
will require some additional work - and at the very least these fixes do
appear to get suspend/resume and runtime PM working the vast majority of
the time.
Thanks for nvidia for providing context into what all of these various
flags and settings do!
Previous version of this patch series:
https://patchwork.freedesktop.org/series/169457/
Patch-wide changes:
* Add magic sleep, this seems to get things stable - but boy I wish I
could figure out why.
Lyude Paul (4):
Revert "nouveau/gsp: fix suspend/resume regression on r570 firmware"
drm/nouveau/gsp/r570: Set GcOff = 0 in fbsr
drm/nouveau/gsp/r570: Enable S/R Display workaround in GSP
drm/nouveau/gsp: Increase delay for magic sleep in r535_gsp_fini()
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fbsr.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 8 ++++++--
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c | 8 ++++----
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c | 3 ++-
.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/nvrm/gsp.h | 8 ++++++++
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h | 2 +-
6 files changed, 22 insertions(+), 9 deletions(-)
base-commit: f29ab62f7ed55eae7b246bb535ede56d3b338674
--
2.55.0
next reply other threads:[~2026-08-14 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 19:43 Lyude Paul [this message]
2026-08-14 19:43 ` [PATCH v5 1/4] Revert "nouveau/gsp: fix suspend/resume regression on r570 firmware" Lyude Paul
2026-08-14 19:43 ` [PATCH v5 2/4] drm/nouveau/gsp/r570: Set GcOff = 0 in fbsr Lyude Paul
2026-08-14 19:43 ` [PATCH v5 3/4] drm/nouveau/gsp/r570: Enable S/R Display workaround in GSP Lyude Paul
2026-08-14 19:43 ` [PATCH v5 4/4] drm/nouveau/gsp: Increase delay for magic sleep in r535_gsp_fini() Lyude Paul
2026-08-14 20:45 ` [PATCH v5 0/4] drm/nouveau: GSP runtime PM fixes David Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814194542.781955-1-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bskeggs@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox