[PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

[PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

[Antonin Malzieu Ridolfi]

[-- Attachment #1.1: Type: text/plain, Size: 2313 bytes --]

Split the gsp register definitions grouped in nova root
register file to the gsp module which actually use them.

Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
Suggested-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Antonin Malzieu Ridolfi <dev@nanonej.com>
---
 drivers/gpu/nova-core/gsp.rs      |  1 +
 drivers/gpu/nova-core/gsp/cmdq.rs |  3 ++-
 drivers/gpu/nova-core/gsp/regs.rs | 11 +++++++++++
 drivers/gpu/nova-core/regs.rs     |  8 --------
 4 files changed, 14 insertions(+), 9 deletions(-)
 create mode 100644 drivers/gpu/nova-core/gsp/regs.rs

diff --git a/drivers/gpu/nova-core/gsp.rs b/drivers/gpu/nova-core/gsp.rs
index 69175ca3315c..385b4c09582b 100644
--- a/drivers/gpu/nova-core/gsp.rs
+++ b/drivers/gpu/nova-core/gsp.rs
@@ -22,6 +22,7 @@
 pub(crate) mod cmdq;
 pub(crate) mod commands;
 mod fw;
+mod regs;
 mod sequencer;

 pub(crate) use fw::{
diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/cmdq.rs
index 0bc5a
95a9cd7..495d07d65c39 100644
--- a/drivers/gpu/nova-core/gsp/cmdq.rs
+++ b/drivers/gpu/nova-core/gsp/cmdq.rs
@@ -51,10 +51,11 @@
         GSP_PAGE_SIZE, //
     },
     num,
-    regs,
     sbuffer::SBufferIter, //
 };

+use super::regs;
+
 /// Marker type representing the absence of a reply for a command. Commands using this as their
 /// reply type are sent using [`Cmdq::send_command_no_wait`].
 pub(crate) struct NoReply;
diff --git a/drivers/gpu/nova-core/gsp/regs.rs b/drivers/gpu/nova-core/gsp/regs.rs
new file mode 100644
index 000000000000..a76dea3c3ab0
--- /dev/null
+++ b/drivers/gpu/nova-core/gsp/regs.rs
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+use kernel::io::register;
+
+// PGSP
+
+register! {
+    pub(super) NV_PGSP_QUEUE_HEAD(u32) @ 0x00110c00 {
+        31:0    address;
+    }
+}
diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
index 0f49c1ab83ad..73339a0cff99 100644
--- a/drivers/gpu/nova-core/reg
s.rs
+++ b/drivers/gpu/nova-core/regs.rs
@@ -227,14 +227,6 @@ pub(crate) fn is_wpr2_set(self) -> bool {
     }
 }

-// PGSP
-
-register! {
-    pub(crate) NV_PGSP_QUEUE_HEAD(u32) @ 0x00110c00 {
-        31:0    address;
-    }
-}
-
 // PGC6 register space.
 //
 // `GC6` is a GPU low-power state where VRAM is in self-refresh and the GPU is powered down (except
--
2.54.0


[-- Attachment #1.2: publickey - dev@nanonej.com - 0x8FBDF600.asc --]
[-- Type: application/pgp-keys, Size: 693 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 322 bytes --]

Re: [PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

[Danilo Krummrich]

On Sun Jun 7, 2026 at 4:10 PM CEST, Antonin Malzieu Ridolfi wrote:
> Split the gsp register definitions grouped in nova root
> register file to the gsp module which actually use them.
>
> Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Antonin Malzieu Ridolfi <dev@nanonej.com>

Thanks for the patch, the contents are fine.

However, the patch is mangled after fetching it with b4 (probably caused by
multipart/signed with nested multipart/mixed); please prefer plain text (see
also [1]).

No need to resend AFAIC; I can also fix it up on my end for this one.

Thanks,
Danilo

[1] https://docs.kernel.org/process/email-clients.html#general-preferences

Re: [PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

[Alexandre Courbot]

On Sun Jun 7, 2026 at 11:10 PM JST, Antonin Malzieu Ridolfi wrote:
> Split the gsp register definitions grouped in nova root
> register file to the gsp module which actually use them.
>
> Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Antonin Malzieu Ridolfi <dev@nanonej.com>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

Re: [PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

[Nanonej Dev]

[-- Attachment #1.1: Type: text/plain, Size: 1276 bytes --]

Oh! Didn't think to add this extra tag since your review, sorry! 

Can we add it now? Should I do a V3 to add it? Or not that much of a big deal this time, but should think about it for the next time? 

Anyway let me know and thanks for the feedback!

Also, I check for Proton Mail, as I understand they don't support `format=flowed` so except using there "uservoice" service to ask them to implement  it, I had probably nothing else to do. But I found a git-protonmail service dedicated to use proton mail with git send-email, so maybe it will work? I have to try as I don't know the email protocol well enough to understand on which layer the patch get mangled and if this tool can proxy around the Proton implementation.

Antonin.

-------- Original Message --------
On Wednesday, 06/10/26 at 15:31 Alexandre Courbot <acourbot@nvidia.com> wrote:
On Sun Jun 7, 2026 at 11:10 PM JST, Antonin Malzieu Ridolfi wrote:
> Split the gsp register definitions grouped in nova root
> register file to the gsp module which actually use them.
>
> Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Antonin Malzieu Ridolfi <dev@nanonej.com>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 343 bytes --]

Re: [PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

[Danilo Krummrich]

On Sun, 07 Jun 2026 14:10:31 +0000, Antonin Malzieu Ridolfi wrote:
> [PATCH v2] gpu: nova-core: gsp: Move gsp register definition into gsp module

Applied, thanks!

  Branch: drm-rust-next
  Tree:   https://gitlab.freedesktop.org/drm/rust/kernel.git

[1/1] gpu: nova-core: gsp: Move gsp register definition into gsp module
      commit: 3e4bac7b8ca7

The patch will appear in the next linux-next integration (typically within 24
hours on weekdays).

The patch is queued up for the upcoming merge window for the next major kernel
release.