Re: [PATCH 6.18 0000/1624] 6.18.40-rc2 review

Re: [PATCH 6.18 0000/1624] 6.18.40-rc2 review

[Miguel Ojeda]

On Wed, 22 Jul 2026 16:31:54 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.18.40 release.
> There are 1624 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 24 Jul 2026 14:26:57 +0000.
> Anything received after that time might be too late.

Boot-tested under QEMU for Rust x86_64, arm64 and riscv64; built-tested
for loongarch64 and arm32:

Tested-by: Miguel Ojeda <ojeda@kernel.org>

I found a build error for all builds with Nova:

    error[E0405]: cannot find trait `FromBytes` in this scope
       --> drivers/gpu/nova-core/vbios.rs:398:13
        |
    398 | unsafe impl FromBytes for BitToken {}
        |             ^^^^^^^^^ not found in this scope
        |
    help: consider importing this trait
        |
    5   + use kernel::transmute::FromBytes;
        |

The reason is that the trait is not imported (and then the function does
not exist in 6.18.y, i.e. `from_bytes_copy_prefix()`).

I suggest dropping commit

  d8fa174e21c8 ("gpu: nova-core: vbios: read BitToken using FromBytes")

for now -- it was not marked for stable, and as far as I know, there are
no production users of Nova, especially in stable kernels.

With that reverted, 6.18.y is fine for me for all builds.

If we want to fix the bug, then we may want a custom minimal patch.

Same applies for -rc1.

Cc: Eliot Courtney <ecourtney@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Eliot Courtney <ecourtney@nvidia.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Alexandre Courbot <acourbot@nvidia.com>
Cc: Alice Ryhl <aliceryhl@google.com>
Cc: nova-gpu@lists.linux.dev

I hope that helps!

Cheers,
Miguel

Re: [PATCH 6.18 0000/1624] 6.18.40-rc2 review

[Danilo Krummrich]

On Thu Jul 23, 2026 at 5:43 PM CEST, Miguel Ojeda wrote:
> I suggest dropping commit
>
>   d8fa174e21c8 ("gpu: nova-core: vbios: read BitToken using FromBytes")
>
> for now -- it was not marked for stable, and as far as I know, there are
> no production users of Nova, especially in stable kernels.

Yes, we can just drop the commit. In general, for now we should only backport
nova patches that could get into the way of testing stable releases in one or
the other way.

> If we want to fix the bug, then we may want a custom minimal patch.

Yeah, I don't think there's much value; in the best case it fixes something that
isn't used in production anyways, and in the worst case it causes noise if it
breaks the build.

> I hope that helps!

Thanks!

Re: [PATCH 6.18 0000/1624] 6.18.40-rc2 review

[Greg KH]

On Thu, Jul 23, 2026 at 10:33:16PM +0200, Danilo Krummrich wrote:
> On Thu Jul 23, 2026 at 5:43 PM CEST, Miguel Ojeda wrote:
> > I suggest dropping commit
> >
> >   d8fa174e21c8 ("gpu: nova-core: vbios: read BitToken using FromBytes")
> >
> > for now -- it was not marked for stable, and as far as I know, there are
> > no production users of Nova, especially in stable kernels.
> 
> Yes, we can just drop the commit. In general, for now we should only backport
> nova patches that could get into the way of testing stable releases in one or
> the other way.

Ok, I'll just drop all the nova patches from 6.18.y and 7.1.y now as
they were not specifically tagged for stable, but just picked up due to
their Fixes: tags.

thanks,

greg k-h