From: Timur Tabi <ttabi@nvidia.com>
To: "gary@garyguo.net" <gary@garyguo.net>,
Alexandre Courbot <acourbot@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
John Hubbard <jhubbard@nvidia.com>
Cc: "lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
Shashank Sharma <shashanks@nvidia.com>,
Zhi Wang <zhiw@nvidia.com>, "simona@ffwll.ch" <simona@ffwll.ch>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
Eliot Courtney <ecourtney@nvidia.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH v2] gpu: nova-core: clarify FSP ordering in the chipset table
Date: Fri, 12 Jun 2026 17:50:32 +0000 [thread overview]
Message-ID: <4bcd28483b8d24397ab2910cb546a038aceef0aa.camel@nvidia.com> (raw)
In-Reply-To: <b51cd866-2224-4f3e-93d5-d7c4288bf2bd@nvidia.com>
On Fri, 2026-06-12 at 10:17 -0700, John Hubbard wrote:
> And clearly the comment has failed in its goal, seeing as how our
> first reader had trouble understanding what we meant. :) Gary,
> any thoughts about how to clarify this? Or is this whole idea
> of talking about Hopper and later turning into a problem...?
I mean, it can't be a problem because that's how everyone in Nvidia talks. The point of the
comment is to reconcile the language we use with the hardware register.
We're not going to stop saying "Hopper and later", and we're never going to mean that to include
Ada.
We probably need to comment the Architecture enum too:
pub(crate) enum Architecture with TryFrom<Bounded<u32, 6>> {
Turing = 0x16,
Ampere = 0x17,
Hopper = 0x18,
Ada = 0x19,
BlackwellGB10x = 0x1a,
BlackwellGB20x = 0x1b,
}
Ugh. Maybe we should swap Hopper and Ada here?
prev parent reply other threads:[~2026-06-12 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 4:04 [PATCH v2] gpu: nova-core: clarify FSP ordering in the chipset table John Hubbard
2026-06-12 12:06 ` Gary Guo
2026-06-12 15:43 ` Timur Tabi
2026-06-12 16:07 ` Gary Guo
2026-06-12 16:24 ` Timur Tabi
2026-06-12 17:17 ` John Hubbard
2026-06-12 17:50 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bcd28483b8d24397ab2910cb546a038aceef0aa.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=shashanks@nvidia.com \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox