From: Timur Tabi <ttabi@nvidia.com>
To: John Hubbard <jhubbard@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>
Cc: Zhi Wang <zhiw@nvidia.com>, "gary@garyguo.net" <gary@garyguo.net>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
Eliot Courtney <ecourtney@nvidia.com>,
"russ.weight@linux.dev" <russ.weight@linux.dev>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"dakr@kernel.org" <dakr@kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"driver-core@lists.linux.dev" <driver-core@lists.linux.dev>
Subject: Re: [PATCH v5 3/8] gpu: nova-core: add TLV parser for firmware files
Date: Wed, 29 Jul 2026 23:02:32 +0000 [thread overview]
Message-ID: <7ab8f580-0bda-4295-bb98-07676f31557a@nvidia.com> (raw)
In-Reply-To: <45a43838-0468-4690-b692-38500f4046e6@nvidia.com>
On 7/29/26 3:09 PM, John Hubbard wrote:
> Agree that there is value in enforcing printable tags. We could
> something like this if we want to allow spaces:
>
> bytes.iter().all(|b| b.is_ascii_graphic() || *b == b' ')
>
> ...but is there really-truly a need to support spaces? (I haven't checked
> on that, but it surprises me at first.)
For tags, no.
But this code is for the value in a string tag, so there could
conceivably be spaces.
I posted a v6 which addresses this.
next prev parent reply other threads:[~2026-07-29 23:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 23:04 [PATCH v5 0/8] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-10 23:04 ` [PATCH v5 1/8] rust: alloc: add Vec::zeroed method Timur Tabi
2026-07-11 13:25 ` Miguel Ojeda
2026-07-13 2:21 ` Timur Tabi
2026-07-27 8:06 ` Alexandre Courbot
2026-07-10 23:04 ` [PATCH v5 2/8] rust: firmware: add request_into_buf() Timur Tabi
2026-07-27 8:06 ` Alexandre Courbot
2026-07-27 10:38 ` Alexandre Courbot
2026-07-10 23:04 ` [PATCH v5 3/8] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-27 11:31 ` Alexandre Courbot
2026-07-29 16:37 ` Timur Tabi
2026-07-29 20:09 ` John Hubbard
2026-07-29 23:02 ` Timur Tabi [this message]
2026-07-10 23:04 ` [PATCH v5 4/8] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-10 23:04 ` [PATCH v5 5/8] gpu: nova-core: transition gsp " Timur Tabi
2026-07-27 11:29 ` Alexandre Courbot
2026-07-10 23:04 ` [PATCH v5 6/8] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-10 23:04 ` [PATCH v5 7/8] gpu: nova-core: transition fsp " Timur Tabi
2026-07-10 23:04 ` [PATCH v5 8/8] gpu: nova-core: update firmware module info for " Timur Tabi
2026-07-27 8:06 ` Alexandre Courbot
2026-07-28 21:54 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ab8f580-0bda-4295-bb98-07676f31557a@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=mcgrof@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox