Re: [PATCH 1/8] rust: firmware: add request_into_buf()

["Danilo Krummrich" <dakr@kernel.org>]

On Thu Jun 11, 2026 at 9:28 PM CEST, Timur Tabi wrote:
> Is having the caller create the subslice on its own such a big deal?  Given
> the returned `size`, the caller already has all the info it needs.  Most
> likely, the caller will want to verify `size` and still use the original
> buffer.

My answer was more about addressing your questions regarding why the approach
would need a lifetime and why it is the better option if you want to do
something with the data before passing it along, and less about expressing an
opinion.

That said, the whole point of the API is that the caller already knows the size
in advance, which is the premise of being able to provide the pre-allocated
buffer in the first place.

For validation the size alone doesn't seem to be overly useful as it is just an
indicator. Either the hardware can report a corrupted image, or you probably
want to do an integrity check in the driver.

Hence, I think this should either return just Result (as nothing else is needed
for now) or a sub-slice. Either is fine with me.