From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Timur Tabi" <ttabi@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Gary Guo" <gary@garyguo.net>, <nova-gpu@lists.linux.dev>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>, <zhiw@nvidia.com>
Subject: Re: [PATCH 8/8] gpu: nova-core: update firmware module info for TLV images
Date: Sat, 13 Jun 2026 00:02:04 +0900 [thread overview]
Message-ID: <DJ75TUE8DMNY.3I4RVB7WCTDJE@nvidia.com> (raw)
In-Reply-To: <20260610174929.744477-9-ttabi@nvidia.com>
On Thu Jun 11, 2026 at 2:49 AM JST, Timur Tabi wrote:
<...>
> @@ -387,20 +367,21 @@ const fn make_entry_chipset(self, chipset: gpu::Chipset) -> Self {
> let name = chipset.name();
>
> let this = self
> - .make_entry_file(name, "bootloader")
> - .make_entry_file(name, "gsp");
> + .make_entry_file(name, "booter_load.tlv")
> + .make_entry_file(name, "gsp.tlv")
> + .make_entry_file(name, "gsp.bin");
>
> // FSP-based chipsets (Hopper, Blackwell and later) boot the GSP via the FMC image loaded by
> // FSP. Older chipsets use the SEC2 booter instead.
> let this = if chipset.uses_fsp() {
> - this.make_entry_file(name, "fmc")
> + this.make_entry_file(name, "fmc.tlv")
> } else {
> - this.make_entry_file(name, "booter_load")
> - .make_entry_file(name, "booter_unload")
> + this.make_entry_file(name, "booter_load.tlv")
`booter_load.tlv` is already unconditionally added above, won't this add
a duplicate entry?
next prev parent reply other threads:[~2026-06-12 15:02 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 17:49 [PATCH 0/8] Transition Nova Core to TLV firmware images Timur Tabi
2026-06-10 17:49 ` [PATCH 1/8] rust: firmware: add request_into_buf() Timur Tabi
2026-06-10 18:03 ` Gary Guo
2026-06-10 18:24 ` Timur Tabi
2026-06-10 20:26 ` Gary Guo
2026-06-10 20:28 ` Timur Tabi
2026-06-10 21:46 ` Danilo Krummrich
2026-06-11 4:58 ` Alexandre Courbot
2026-06-11 15:48 ` Timur Tabi
2026-06-11 6:49 ` Alexandre Courbot
2026-06-11 16:32 ` Timur Tabi
2026-06-11 19:18 ` Danilo Krummrich
2026-06-11 19:28 ` Timur Tabi
2026-06-11 19:31 ` John Hubbard
2026-06-11 20:01 ` Timur Tabi
2026-06-11 21:55 ` John Hubbard
2026-06-11 21:56 ` Danilo Krummrich
2026-06-11 21:49 ` Danilo Krummrich
2026-06-12 2:59 ` Alexandre Courbot
2026-06-12 14:51 ` Alexandre Courbot
2026-06-10 17:49 ` [PATCH 2/8] gpu: nova-core: add request_tlv to load TLV images Timur Tabi
2026-06-10 22:00 ` Danilo Krummrich
2026-06-11 16:45 ` Timur Tabi
2026-06-11 18:17 ` Gary Guo
2026-06-11 18:26 ` Timur Tabi
2026-06-11 18:42 ` Gary Guo
2026-06-11 18:53 ` Timur Tabi
2026-06-11 19:16 ` John Hubbard
2026-06-11 18:53 ` Danilo Krummrich
2026-06-11 18:57 ` Timur Tabi
2026-06-10 17:49 ` [PATCH 3/8] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-06-10 22:37 ` Danilo Krummrich
2026-06-11 6:51 ` Alexandre Courbot
2026-06-11 18:40 ` John Hubbard
2026-06-11 23:29 ` Timur Tabi
2026-06-12 14:46 ` Alexandre Courbot
2026-06-12 18:04 ` Timur Tabi
2026-06-12 23:27 ` Alexandre Courbot
2026-06-12 23:39 ` John Hubbard
2026-06-10 17:49 ` [PATCH 4/8] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-06-10 17:49 ` [PATCH 5/8] gpu: nova-core: transition gsp " Timur Tabi
2026-06-10 17:49 ` [PATCH 6/8] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-06-10 17:49 ` [PATCH 7/8] gpu: nova-core: transition fsp " Timur Tabi
2026-06-10 17:49 ` [PATCH 8/8] gpu: nova-core: update firmware module info for " Timur Tabi
2026-06-12 15:02 ` Alexandre Courbot [this message]
2026-06-12 15:44 ` Timur Tabi
2026-06-10 18:16 ` [PATCH 0/8] Transition Nova Core to TLV firmware images John Hubbard
2026-06-10 18:19 ` Timur Tabi
2026-06-10 18:59 ` Timur Tabi
2026-06-10 21:21 ` John Hubbard
2026-06-10 21:43 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJ75TUE8DMNY.3I4RVB7WCTDJE@nvidia.com \
--to=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=nova-gpu@lists.linux.dev \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox