From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Nanonej Dev" <dev@nanonej.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>, <nova-gpu@lists.linux.dev>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<daniel.almeida@collabora.com>
Subject: Re: [PATCH 3/3] gpu: nova-core: Move one PBUS register definition
Date: Sat, 25 Jul 2026 22:28:03 +0900 [thread overview]
Message-ID: <DK7ORAEDUILT.3788O3AIQZQUO@nvidia.com> (raw)
In-Reply-To: <TPL-Nmz1jd_sB3sr_x-746jIwTxY7IRTMU5b8jwBv1ice0C31BNvqzUzo3s68ZkE1-mfZHAx2SURO54hHnbR8CUPo3rNLnfHIs_ujtl8D_Q=@nanonej.com>
On Wed Jul 22, 2026 at 12:51 AM JST, Nanonej Dev wrote:
>> - Move the `NV_PBUS_SW_SCRATCH_0E_FRTS_ERR` register under the `gsp`
>> module, since it is clearly themed after `FRTS`, which is part of the
>> GSP boot. But, without moving `NV_PBUS_SW_SCRATCH` (the actual
>> register being aliased). I expect you will hit a bug of the `register`
>> macro when doing this one - I'll try to address it, but the first two
>> steps should be safe to do and correct.
>
> You told me that I would hit a bug on `NV_PBUS_SW_SCRATCH`, but as far as I compile, I didn't. Anything I could have missed?
I was expecting issues with relative registers that need to refer to a
base type defined in another module; but as relative registers should be
going away soon [1], so will this problem. IOW, I suggest waiting a bit
before attempting to move the PFALCON/PFALCON2 registers.
[1] https://lore.kernel.org/all/20260721-typed_register-v1-0-452d72b60262@garyguo.net/
next prev parent reply other threads:[~2026-07-25 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 15:41 [PATCH 0/3] gpu: nova-core: Move PFB and PBUS register Antonin Malzieu Ridolfi via B4 Relay
2026-07-21 15:41 ` [PATCH 1/3] gpu: nova-core: Add function to query WPR2 range Antonin Malzieu Ridolfi via B4 Relay
2026-07-25 13:24 ` Alexandre Courbot
2026-07-21 15:41 ` [PATCH 2/3] gpu: nova-core: Move PFB registers definitions Antonin Malzieu Ridolfi via B4 Relay
2026-07-25 13:27 ` Alexandre Courbot
2026-07-21 15:41 ` [PATCH 3/3] gpu: nova-core: Move one PBUS register definition Antonin Malzieu Ridolfi via B4 Relay
2026-07-21 15:51 ` Nanonej Dev
2026-07-25 13:28 ` Alexandre Courbot [this message]
2026-07-25 13:30 ` Alexandre Courbot
2026-07-21 15:46 ` [PATCH 0/3] gpu: nova-core: Move PFB and PBUS register Nanonej Dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK7ORAEDUILT.3788O3AIQZQUO@nvidia.com \
--to=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dev@nanonej.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox