Re: [PATCH 2/5] gpu: nova-core: merge LibosParams into GspFwHeapParams

["Eliot Courtney" <ecourtney@nvidia.com>]

On Wed Nov 11, 2026 at 8:10 AM JST, Timur Tabi wrote:
> LibosParams and GspFwHeapParams are two types used to hold data and/or
> methods for calculating the heap sides that GSP-RM needs for booting.
> Although they technically represent distinct parts of the equations,
> they are always used together.
>
> A future change to this code will introduce runtime calculations based
> on values extracted from the GSP-RM, replacing the compile-time
> constants currently used.  Merging the two types in this commit keeps
> the current functionality while providing a foundation that simplifies
> future changes.
>
> For the same reason, the LIBOSx constants are replaced with variables.
>
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
> ---

The direction of this series looks good to me, but I think there's some
unnecessary churn from moving the functions from LibosParams now, rather
than switching over after adding the TLV values to GspFwHeapParams. What
about doing essentially patch #1 then patch #3 (which doesn't need the
zero dummy vals if #2 is removed) of this series, then a patch each for
switching over
- non-wpr heap + pmu reserved size (+drop hal functions)
- vGPU stuff
- WPR2 heap size

I tried this locally and it seems to remove a bunch of the churn.

WDYT?