Re: [PATCH v5 12/14] gpu: nova-core: gsp: cmdq: move the RPC code into a sub-module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpu: nova-core: split kernel::time import block in cmdq.rs
--

commit 33237ce05e59a6a327898e33f27b96ad56cf0c7f
Author: Alexandre Courbot <acourbot@nvidia.com>

gpu: nova-core: gsp: cmdq: move the RPC code into a sub-module

This commit moves the RPC command and message types and methods from
drivers/gpu/nova-core/gsp/cmdq.rs into a new rpc sub-module.

> diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/cmdq.rs
> index 54e87fd7158cd..c5a2f08cda94a 100644
> --- a/drivers/gpu/nova-core/gsp/cmdq.rs
> +++ b/drivers/gpu/nova-core/gsp/cmdq.rs

[ ... ]

> @@ -28,8 +29,8 @@
>          },
>          Mutex, //
>      },
> +    time::Delta,
>      time::{
> -        Delta,
>          Instant,
>          Monotonic, //
>      },

[Severity: Low]
This isn't a bug, but in the use kernel declaration in
drivers/gpu/nova-core/gsp/cmdq.rs, Delta was moved out of the time::{ ... }
group into a separate time::Delta entry above time::{ Instant, Monotonic }.
Should Delta remain grouped inside the single time::{ ... } block to follow
the kernel vertical import style?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261020-cmdq-rpc-v5-0-dceeb8f360ec@nvidia.com?part=12