From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: 'Logan Gunthorpe' <logang@deltatee.com>, linux-ntb@googlegroups.com
Cc: 'Jon Mason' <jdmason@kudzu.us>
Subject: RE: [PATCH] NTB: ntb_test: fix bug printing ntb_perf results
Date: Mon, 5 Jun 2017 13:58:11 -0400 [thread overview]
Message-ID: <000001d2de25$4c858260$e5908720$@dell.com> (raw)
In-Reply-To: <20170605161324.11696-1-logang@deltatee.com>
From: Logan Gunthorpe
> The code mistakenly prints the local perf results for the remote test
> so the script reports identical results for both directions. Fix this
> by ensuring we print the remote result.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Jon Mason <jdmason@kudzu.us>
> Cc: Allen Hubbe <Allen.Hubbe@dell.com>
Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
> ---
>
> Oops, this was my own bug.
>
> tools/testing/selftests/ntb/ntb_test.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ntb/ntb_test.sh
> b/tools/testing/selftests/ntb/ntb_test.sh
> index a676d3eefefb..13f5198ba0ee 100755
> --- a/tools/testing/selftests/ntb/ntb_test.sh
> +++ b/tools/testing/selftests/ntb/ntb_test.sh
> @@ -305,7 +305,7 @@ function perf_test()
> echo "Running remote perf test $WITH DMA"
> write_file "" $REMOTE_PERF/run
> echo -n " "
> - read_file $LOCAL_PERF/run
> + read_file $REMOTE_PERF/run
> echo " Passed"
>
> _modprobe -r ntb_perf
> --
> 2.11.0
next prev parent reply other threads:[~2017-06-05 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 16:13 [PATCH] NTB: ntb_test: fix bug printing ntb_perf results Logan Gunthorpe
2017-06-05 17:58 ` Allen Hubbe [this message]
2017-06-21 7:22 ` kpriyambada48
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d2de25$4c858260$e5908720$@dell.com' \
--to=allen.hubbe@dell.com \
--cc=jdmason@kudzu.us \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox