[PATCH] NTB: ntb_test: fix bug printing ntb_perf results

[PATCH] NTB: ntb_test: fix bug printing ntb_perf results

[Logan Gunthorpe]

The code mistakenly prints the local perf results for the remote test
so the script reports identical results for both directions. Fix this
by ensuring we print the remote result.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Cc: Jon Mason <jdmason@kudzu.us>
Cc: Allen Hubbe <Allen.Hubbe@dell.com>
---

 Oops, this was my own bug.

 tools/testing/selftests/ntb/ntb_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index a676d3eefefb..13f5198ba0ee 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -305,7 +305,7 @@ function perf_test()
 	echo "Running remote perf test $WITH DMA"
 	write_file "" $REMOTE_PERF/run
 	echo -n "  "
-	read_file $LOCAL_PERF/run
+	read_file $REMOTE_PERF/run
 	echo "  Passed"

 	_modprobe -r ntb_perf
--
2.11.0

RE: [PATCH] NTB: ntb_test: fix bug printing ntb_perf results

[Allen Hubbe]

From: Logan Gunthorpe
> The code mistakenly prints the local perf results for the remote test
> so the script reports identical results for both directions. Fix this
> by ensuring we print the remote result.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Jon Mason <jdmason@kudzu.us>
> Cc: Allen Hubbe <Allen.Hubbe@dell.com>

Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>

> ---
> 
>  Oops, this was my own bug.
> 
>  tools/testing/selftests/ntb/ntb_test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ntb/ntb_test.sh
> b/tools/testing/selftests/ntb/ntb_test.sh
> index a676d3eefefb..13f5198ba0ee 100755
> --- a/tools/testing/selftests/ntb/ntb_test.sh
> +++ b/tools/testing/selftests/ntb/ntb_test.sh
> @@ -305,7 +305,7 @@ function perf_test()
>  	echo "Running remote perf test $WITH DMA"
>  	write_file "" $REMOTE_PERF/run
>  	echo -n "  "
> -	read_file $LOCAL_PERF/run
> +	read_file $REMOTE_PERF/run
>  	echo "  Passed"
> 
>  	_modprobe -r ntb_perf
> --
> 2.11.0

Re: [PATCH] NTB: ntb_test: fix bug printing ntb_perf results

[kpriyambada48]

[-- Attachment #1.1: Type: text/plain, Size: 1150 bytes --]



On Monday, June 5, 2017 at 9:43:34 PM UTC+5:30, Logan Gunthorpe wrote:
>
> The code mistakenly prints the local perf results for the remote test 
> so the script reports identical results for both directions. Fix this 
> by ensuring we print the remote result. 
>
> Signed-off-by: Logan Gunthorpe <log...@deltatee.com <javascript:>> 
> Cc: Jon Mason <jdm...@kudzu.us <javascript:>> 
> Cc: Allen Hubbe <Allen...@dell.com <javascript:>> 
> --- 
>
>  Oops, this was my own bug. 
>
>  tools/testing/selftests/ntb/ntb_test.sh | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/tools/testing/selftests/ntb/ntb_test.sh 
> b/tools/testing/selftests/ntb/ntb_test.sh 
> index a676d3eefefb..13f5198ba0ee 100755 
> --- a/tools/testing/selftests/ntb/ntb_test.sh 
> +++ b/tools/testing/selftests/ntb/ntb_test.sh 
> @@ -305,7 +305,7 @@ function perf_test() 
>          echo "Running remote perf test $WITH DMA" 
>          write_file "" $REMOTE_PERF/run 
>          echo -n "  " 
> -        read_file $LOCAL_PERF/run 
> +        read_file $REMOTE_PERF/run 
>          echo "  Passed" 
>
>          _modprobe -r ntb_perf 
> -- 
> 2.11.0 
>

[-- Attachment #1.2: Type: text/html, Size: 2097 bytes --]