ntb.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: 'Dave Jiang' <dave.jiang@intel.com>, jdmason@kudzu.us
Cc: linux-ntb@googlegroups.com, ujjal.singh@intel.com
Subject: RE: [PATCH v2] ntb: ntb_hw_intel: Skylake doorbells should be 32bits, not 64bits
Date: Fri, 9 Jun 2017 09:51:30 -0400	[thread overview]
Message-ID: <000001d2e127$7fb8d740$7f2a85c0$@dell.com> (raw)
In-Reply-To: <149695115133.26451.13997592259493006219.stgit@djiang5-desk3.ch.intel.com>

From: Dave Jiang 
> Fixing doorbell register length to 32bits per spec. On Skylake NTB, the
> doorbell registers are 32bit write only registers. The source for the doorbell is
> a 64bit register that shows the interrupt bits.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>

> ---
> 
> v2: Allen: remove unnecessary change to code.
> 
>  drivers/ntb/hw/intel/ntb_hw_intel.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c
> b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index c002384..7b3b6fd 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -2878,7 +2878,7 @@ static const struct intel_ntb_reg skx_reg = {
>  	.link_is_up		= xeon_link_is_up,
>  	.db_ioread		= skx_db_ioread,
>  	.db_iowrite		= skx_db_iowrite,
> -	.db_size		= sizeof(u64),
> +	.db_size		= sizeof(u32),
>  	.ntb_ctl		= SKX_NTBCNTL_OFFSET,
>  	.mw_bar			= {2, 4},
>  };



  reply	other threads:[~2017-06-09 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 19:46 [PATCH v2] ntb: ntb_hw_intel: Skylake doorbells should be 32bits, not 64bits Dave Jiang
2017-06-09 13:51 ` Allen Hubbe [this message]
2017-06-09 21:08   ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d2e127$7fb8d740$7f2a85c0$@dell.com' \
    --to=allen.hubbe@dell.com \
    --cc=dave.jiang@intel.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-ntb@googlegroups.com \
    --cc=ujjal.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).