Linux PCI Non-Transparent Bridge framework and drivers
 help / color / mirror / Atom feed
From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: 'Allen Hubbe' <Allen.Hubbe@dell.com>,
	'Aaron Sierra' <asierra@xes-inc.com>,
	'Jon Mason' <jdmason@kudzu.us>,
	'Dave Jiang' <dave.jiang@intel.com>
Cc: linux-ntb@googlegroups.com, 'Jiri Kosina' <trivial@kernel.org>
Subject: RE: correct ntb_spad_count comment typo
Date: Wed, 7 Dec 2016 10:09:45 -0500	[thread overview]
Message-ID: <000101d2509b$f25511a0$d6ff34e0$@dell.com> (raw)
In-Reply-To: <000001d2509b$2d829050$8887b0f0$@dell.com>

From: Allen Hubbe
> From: Aaron Sierra
> > The comment for ntb_spad_count incorrectly referred to ntb_mw_count.
> >
> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
> 
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
> 

Actually, the commit subject line should include the subsystem name.

"NTB: Correct ntb_spad_count comment typo"

John might fix this after accepting the patch as is, but it would be easier if you amend the commit and send v2 with a new subject line.

Thanks,
Allen

> > ---
> >  include/linux/ntb.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/ntb.h b/include/linux/ntb.h
> > index 6f47562..50a7dbe 100644
> > --- a/include/linux/ntb.h
> > +++ b/include/linux/ntb.h
> > @@ -892,15 +892,15 @@ static inline int ntb_spad_is_unsafe(struct ntb_dev *ntb)
> >  	if (!ntb->ops->spad_is_unsafe)
> >  		return 0;
> >
> >  	return ntb->ops->spad_is_unsafe(ntb);
> >  }
> >
> >  /**
> > - * ntb_mw_count() - get the number of scratchpads
> > + * ntb_spad_count() - get the number of scratchpads
> >   * @ntb:	NTB device context.
> >   *
> >   * Hardware and topology may support a different number of scratchpads.
> >   *
> >   * Return: the number of scratchpads.
> >   */
> >  static inline int ntb_spad_count(struct ntb_dev *ntb)
> > --
> > 1.9.1
> 
> 
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb"
> group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-
> ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-
> ntb/000001d2509b%242d829050%248887b0f0%24%40dell.com.
> For more options, visit https://groups.google.com/d/optout.


  reply	other threads:[~2016-12-07 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  1:09 [PATCH] NTB: correct ntb_spad_count comment typo Aaron Sierra
2016-12-07 15:04 ` Allen Hubbe
2016-12-07 15:09   ` Allen Hubbe [this message]
2016-12-07 17:33     ` Aaron Sierra
2016-12-07 18:35       ` Allen Hubbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101d2509b$f25511a0$d6ff34e0$@dell.com' \
    --to=allen.hubbe@dell.com \
    --cc=asierra@xes-inc.com \
    --cc=dave.jiang@intel.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-ntb@googlegroups.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox