From: Aaron Sierra <asierra@xes-inc.com>
To: Allen Hubbe <Allen.Hubbe@dell.com>
Cc: Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
linux-ntb <linux-ntb@googlegroups.com>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: correct ntb_spad_count comment typo
Date: Wed, 7 Dec 2016 11:33:51 -0600 (CST) [thread overview]
Message-ID: <1763865308.471858.1481132031876.JavaMail.zimbra@xes-inc.com> (raw)
In-Reply-To: <000101d2509b$f25511a0$d6ff34e0$@dell.com>
----- Original Message -----
> From: "Allen Hubbe" <Allen.Hubbe@dell.com>
> Sent: Wednesday, December 7, 2016 9:09:45 AM
> From: Allen Hubbe
>> From: Aaron Sierra
>> > The comment for ntb_spad_count incorrectly referred to ntb_mw_count.
>> >
>> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
>>
>> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
>>
>
> Actually, the commit subject line should include the subsystem name.
>
> "NTB: Correct ntb_spad_count comment typo"
Allen,
First of all, thanks for taking time to review my patch!
This is the exact subject that I sent out:
[PATCH] NTB: correct ntb_spad_count comment typo
Hopefully, this is just a glitch between me and you.
>
> John might fix this after accepting the patch as is, but it would be easier if
> you amend the commit and send v2 with a new subject line.
>
Can anyone else confirm or deny the need for a v2?
-Aaron S.
next prev parent reply other threads:[~2016-12-07 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 1:09 [PATCH] NTB: correct ntb_spad_count comment typo Aaron Sierra
2016-12-07 15:04 ` Allen Hubbe
2016-12-07 15:09 ` Allen Hubbe
2016-12-07 17:33 ` Aaron Sierra [this message]
2016-12-07 18:35 ` Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1763865308.471858.1481132031876.JavaMail.zimbra@xes-inc.com \
--to=asierra@xes-inc.com \
--cc=Allen.Hubbe@dell.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-ntb@googlegroups.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox