Linux PCI Non-Transparent Bridge framework and drivers
 help / color / mirror / Atom feed
From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: "Wahl, Steve" <Steve.Wahl@dell.com>, linux-ntb@googlegroups.com
Subject: RE: [PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read.
Date: Thu, 8 Dec 2016 12:16:45 -0500	[thread overview]
Message-ID: <002001d25176$da7cabc0$8f760340$@dell.com> (raw)
In-Reply-To: <89e7f17cb62a4a62a02673b10bf4a967@mspexmb1.Beer.Town>

From: Steven Wahl 
> The results were previously ignored, anyway.
> 
> Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>

Fixes: e26a5843f7f5014ae4460030ca4de029a3ac35d3

Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>

> ---
>  drivers/ntb/ntb_transport.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 4eb8adb..cd9a392 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -960,7 +960,6 @@ static void ntb_qp_link_work(struct work_struct *work)
>         ntb_peer_spad_write(nt->ndev, QP_LINKS, val | BIT(qp->qp_num));
> 
>         /* query remote spad for qp ready bits */
> -       ntb_peer_spad_read(nt->ndev, QP_LINKS);
>         dev_dbg_ratelimited(&pdev->dev, "Remote QP link status = %x\n", val);
> 
>         /* See if the remote side is up */
> --
> 2.7.4


  reply	other threads:[~2016-12-08 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <297aec6b47924ce9889abe4d6c51c173@mspexmb1.Beer.Town>
2016-12-08 17:03 ` [PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read Steven Wahl
2016-12-08 17:16   ` Allen Hubbe [this message]
2016-12-21 16:48     ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002001d25176$da7cabc0$8f760340$@dell.com' \
    --to=allen.hubbe@dell.com \
    --cc=Steve.Wahl@dell.com \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox