From: Jon Mason <jdmason@kudzu.us>
To: Allen Hubbe <Allen.Hubbe@dell.com>
Cc: "Wahl, Steve" <Steve.Wahl@dell.com>, linux-ntb@googlegroups.com
Subject: Re: [PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read.
Date: Wed, 21 Dec 2016 11:48:07 -0500 [thread overview]
Message-ID: <20161221164807.GB32599@kudzu.us> (raw)
In-Reply-To: <002001d25176$da7cabc0$8f760340$@dell.com>
On Thu, Dec 08, 2016 at 12:16:45PM -0500, Allen Hubbe wrote:
> From: Steven Wahl
> > The results were previously ignored, anyway.
> >
> > Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>
>
> Fixes: e26a5843f7f5014ae4460030ca4de029a3ac35d3
>
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
This patch also didn't apply cleanly. I hand applied it, as it was a
simple patch.
Thanks,
Jon
>
> > ---
> > drivers/ntb/ntb_transport.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> > index 4eb8adb..cd9a392 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -960,7 +960,6 @@ static void ntb_qp_link_work(struct work_struct *work)
> > ntb_peer_spad_write(nt->ndev, QP_LINKS, val | BIT(qp->qp_num));
> >
> > /* query remote spad for qp ready bits */
> > - ntb_peer_spad_read(nt->ndev, QP_LINKS);
> > dev_dbg_ratelimited(&pdev->dev, "Remote QP link status = %x\n", val);
> >
> > /* See if the remote side is up */
> > --
> > 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/002001d25176%24da7cabc0%248f760340%24%40dell.com.
> For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2016-12-21 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <297aec6b47924ce9889abe4d6c51c173@mspexmb1.Beer.Town>
2016-12-08 17:03 ` [PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read Steven Wahl
2016-12-08 17:16 ` Allen Hubbe
2016-12-21 16:48 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221164807.GB32599@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Allen.Hubbe@dell.com \
--cc=Steve.Wahl@dell.com \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox