Linux PCI Non-Transparent Bridge framework and drivers
 help / color / mirror / Atom feed
From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: "Wahl, Steve" <Steve.Wahl@dell.com>, linux-ntb@googlegroups.com
Subject: RE: [PATCH] NTB: correct ntb_peer_spad_read for case when callback is not supplied.
Date: Thu, 8 Dec 2016 12:16:57 -0500	[thread overview]
Message-ID: <002101d25176$e14ac450$a3e04cf0$@dell.com> (raw)
In-Reply-To: <b40a94020de44fb6974bfcc978d1ce52@mspexmb1.Beer.Town>

From: Steven Wahl
>
> Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>

The only thing lacking here is a commit comment, but the change is self-explanatory.  Thanks!

Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>

> ---
>  include/linux/ntb.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/ntb.h b/include/linux/ntb.h
> index 6f47562..816bd98 100644
> --- a/include/linux/ntb.h
> +++ b/include/linux/ntb.h
> @@ -968,6 +968,9 @@ static inline int ntb_peer_spad_addr(struct ntb_dev *ntb, int idx,
>   */
>  static inline u32 ntb_peer_spad_read(struct ntb_dev *ntb, int idx)
>  {
> +       if (!ntb->ops->peer_spad_read)
> +               return 0;
> +
>         return ntb->ops->peer_spad_read(ntb, idx);
>  }
> 
> --
> 2.7.4


  reply	other threads:[~2016-12-08 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2a1282ae9ad64a34b4795541a2c290b5@mspexmb1.Beer.Town>
2016-12-08 17:02 ` [PATCH] NTB: correct ntb_peer_spad_read for case when callback is not supplied Steven Wahl
2016-12-08 17:16   ` Allen Hubbe [this message]
2016-12-21 16:40     ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002101d25176$e14ac450$a3e04cf0$@dell.com' \
    --to=allen.hubbe@dell.com \
    --cc=Steve.Wahl@dell.com \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox