From: Jon Mason <jdmason@kudzu.us>
To: Allen Hubbe <Allen.Hubbe@dell.com>
Cc: "Wahl, Steve" <Steve.Wahl@dell.com>, linux-ntb@googlegroups.com
Subject: Re: [PATCH] NTB: correct ntb_peer_spad_read for case when callback is not supplied.
Date: Wed, 21 Dec 2016 11:40:41 -0500 [thread overview]
Message-ID: <20161221164040.GA32599@kudzu.us> (raw)
In-Reply-To: <002101d25176$e14ac450$a3e04cf0$@dell.com>
On Thu, Dec 08, 2016 at 12:16:57PM -0500, Allen Hubbe wrote:
> From: Steven Wahl
> >
> > Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>
>
> The only thing lacking here is a commit comment, but the change is self-explanatory. Thanks!
>
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
This didn't apply cleanly for some reason. I hand applied it, as it
was a simple patch and duplicated the title into the body of the
commit.
Thanks,
Jon
>
> > ---
> > include/linux/ntb.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/ntb.h b/include/linux/ntb.h
> > index 6f47562..816bd98 100644
> > --- a/include/linux/ntb.h
> > +++ b/include/linux/ntb.h
> > @@ -968,6 +968,9 @@ static inline int ntb_peer_spad_addr(struct ntb_dev *ntb, int idx,
> > */
> > static inline u32 ntb_peer_spad_read(struct ntb_dev *ntb, int idx)
> > {
> > + if (!ntb->ops->peer_spad_read)
> > + return 0;
> > +
> > return ntb->ops->peer_spad_read(ntb, idx);
> > }
> >
> > --
> > 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/002101d25176%24e14ac450%24a3e04cf0%24%40dell.com.
> For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2016-12-21 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2a1282ae9ad64a34b4795541a2c290b5@mspexmb1.Beer.Town>
2016-12-08 17:02 ` [PATCH] NTB: correct ntb_peer_spad_read for case when callback is not supplied Steven Wahl
2016-12-08 17:16 ` Allen Hubbe
2016-12-21 16:40 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221164040.GA32599@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Allen.Hubbe@dell.com \
--cc=Steve.Wahl@dell.com \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox