* [PATCH 1/2] NTB: ntb_test: modprobe on remote host
@ 2016-12-28 0:12 Allen Hubbe
2016-12-28 0:12 ` [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask Allen Hubbe
2016-12-28 0:16 ` [PATCH 1/2] NTB: ntb_test: modprobe on remote host Logan Gunthorpe
0 siblings, 2 replies; 6+ messages in thread
From: Allen Hubbe @ 2016-12-28 0:12 UTC (permalink / raw)
To: linux-ntb; +Cc: Jon Mason, Logan Gunthorpe, Allen Hubbe
Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>
---
tools/testing/selftests/ntb/ntb_test.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index a676d3eefefb..4e70e19255bc 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -85,6 +85,10 @@ set -e
function _modprobe()
{
modprobe "$@"
+
+ if [[ "$REMOTE_HOST" != "" ]]; then
+ ssh "$REMOTE_HOST" modprobe "$@"
+ fi
}
function split_remote()
--
2.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask
2016-12-28 0:12 [PATCH 1/2] NTB: ntb_test: modprobe on remote host Allen Hubbe
@ 2016-12-28 0:12 ` Allen Hubbe
2016-12-28 0:17 ` Logan Gunthorpe
2016-12-28 0:16 ` [PATCH 1/2] NTB: ntb_test: modprobe on remote host Logan Gunthorpe
1 sibling, 1 reply; 6+ messages in thread
From: Allen Hubbe @ 2016-12-28 0:12 UTC (permalink / raw)
To: linux-ntb; +Cc: Jon Mason, Logan Gunthorpe, Allen Hubbe
If the test attempts to clear doorbell bits that are invalid for the
hardware, then the test will fail. Provide a parameter to specify the
doorbell bits to clear. Set default doorbell bits that work for XEON.
Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>
---
tools/testing/selftests/ntb/ntb_test.sh | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index 4e70e19255bc..d25b91b2ee2e 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -18,6 +18,7 @@ LIST_DEVS=FALSE
DEBUGFS=${DEBUGFS-/sys/kernel/debug}
+DB_BITMASK=0x7FFF
PERF_RUN_ORDER=32
MAX_MW_SIZE=0
RUN_DMA_TESTS=
@@ -38,6 +39,7 @@ function show_help()
echo "be highly recommended."
echo
echo "Options:"
+ echo " -b BITMASK doorbell clear bitmask for ntb_tool"
echo " -C don't cleanup ntb modules on exit"
echo " -d run dma tests"
echo " -h show this help message"
@@ -52,8 +54,9 @@ function show_help()
function parse_args()
{
OPTIND=0
- while getopts "Cdhlm:r:p:w:" opt; do
+ while getopts "b:Cdhlm:r:p:w:" opt; do
case "$opt" in
+ b) DB_BITMASK=${OPTARG} ;;
C) DONT_CLEANUP=1 ;;
d) RUN_DMA_TESTS=1 ;;
h) show_help; exit 0 ;;
@@ -158,7 +161,7 @@ function doorbell_test()
echo "Running db tests on: $(basename $LOC) / $(basename $REM)"
- write_file "c 0xFFFFFFFF" "$REM/db"
+ write_file "c $DB_BITMASK" "$REM/db"
for ((i=1; i <= 8; i++)); do
let DB=$(read_file "$REM/db") || true
--
2.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask
2016-12-28 0:12 ` [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask Allen Hubbe
@ 2016-12-28 0:17 ` Logan Gunthorpe
2017-01-10 21:45 ` Jon Mason
0 siblings, 1 reply; 6+ messages in thread
From: Logan Gunthorpe @ 2016-12-28 0:17 UTC (permalink / raw)
To: Allen Hubbe, linux-ntb; +Cc: Jon Mason
Ditto.
Acked-by: Logan Gunthorpe <logang@deltatee.com>
On 27/12/16 05:12 PM, Allen Hubbe wrote:
> If the test attempts to clear doorbell bits that are invalid for the
> hardware, then the test will fail. Provide a parameter to specify the
> doorbell bits to clear. Set default doorbell bits that work for XEON.
>
> Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>
> ---
> tools/testing/selftests/ntb/ntb_test.sh | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
> index 4e70e19255bc..d25b91b2ee2e 100755
> --- a/tools/testing/selftests/ntb/ntb_test.sh
> +++ b/tools/testing/selftests/ntb/ntb_test.sh
> @@ -18,6 +18,7 @@ LIST_DEVS=FALSE
>
> DEBUGFS=${DEBUGFS-/sys/kernel/debug}
>
> +DB_BITMASK=0x7FFF
> PERF_RUN_ORDER=32
> MAX_MW_SIZE=0
> RUN_DMA_TESTS=
> @@ -38,6 +39,7 @@ function show_help()
> echo "be highly recommended."
> echo
> echo "Options:"
> + echo " -b BITMASK doorbell clear bitmask for ntb_tool"
> echo " -C don't cleanup ntb modules on exit"
> echo " -d run dma tests"
> echo " -h show this help message"
> @@ -52,8 +54,9 @@ function show_help()
> function parse_args()
> {
> OPTIND=0
> - while getopts "Cdhlm:r:p:w:" opt; do
> + while getopts "b:Cdhlm:r:p:w:" opt; do
> case "$opt" in
> + b) DB_BITMASK=${OPTARG} ;;
> C) DONT_CLEANUP=1 ;;
> d) RUN_DMA_TESTS=1 ;;
> h) show_help; exit 0 ;;
> @@ -158,7 +161,7 @@ function doorbell_test()
>
> echo "Running db tests on: $(basename $LOC) / $(basename $REM)"
>
> - write_file "c 0xFFFFFFFF" "$REM/db"
> + write_file "c $DB_BITMASK" "$REM/db"
>
> for ((i=1; i <= 8; i++)); do
> let DB=$(read_file "$REM/db") || true
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask
2016-12-28 0:17 ` Logan Gunthorpe
@ 2017-01-10 21:45 ` Jon Mason
0 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2017-01-10 21:45 UTC (permalink / raw)
To: Logan Gunthorpe; +Cc: Allen Hubbe, linux-ntb
On Tue, Dec 27, 2016 at 05:17:07PM -0700, Logan Gunthorpe wrote:
> Ditto.
>
> Acked-by: Logan Gunthorpe <logang@deltatee.com>
>
> On 27/12/16 05:12 PM, Allen Hubbe wrote:
> > If the test attempts to clear doorbell bits that are invalid for the
> > hardware, then the test will fail. Provide a parameter to specify the
> > doorbell bits to clear. Set default doorbell bits that work for XEON.
> >
> > Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>
Applied to my ntb tree
Thanks,
Jon
> > ---
> > tools/testing/selftests/ntb/ntb_test.sh | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
> > index 4e70e19255bc..d25b91b2ee2e 100755
> > --- a/tools/testing/selftests/ntb/ntb_test.sh
> > +++ b/tools/testing/selftests/ntb/ntb_test.sh
> > @@ -18,6 +18,7 @@ LIST_DEVS=FALSE
> >
> > DEBUGFS=${DEBUGFS-/sys/kernel/debug}
> >
> > +DB_BITMASK=0x7FFF
> > PERF_RUN_ORDER=32
> > MAX_MW_SIZE=0
> > RUN_DMA_TESTS=
> > @@ -38,6 +39,7 @@ function show_help()
> > echo "be highly recommended."
> > echo
> > echo "Options:"
> > + echo " -b BITMASK doorbell clear bitmask for ntb_tool"
> > echo " -C don't cleanup ntb modules on exit"
> > echo " -d run dma tests"
> > echo " -h show this help message"
> > @@ -52,8 +54,9 @@ function show_help()
> > function parse_args()
> > {
> > OPTIND=0
> > - while getopts "Cdhlm:r:p:w:" opt; do
> > + while getopts "b:Cdhlm:r:p:w:" opt; do
> > case "$opt" in
> > + b) DB_BITMASK=${OPTARG} ;;
> > C) DONT_CLEANUP=1 ;;
> > d) RUN_DMA_TESTS=1 ;;
> > h) show_help; exit 0 ;;
> > @@ -158,7 +161,7 @@ function doorbell_test()
> >
> > echo "Running db tests on: $(basename $LOC) / $(basename $REM)"
> >
> > - write_file "c 0xFFFFFFFF" "$REM/db"
> > + write_file "c $DB_BITMASK" "$REM/db"
> >
> > for ((i=1; i <= 8; i++)); do
> > let DB=$(read_file "$REM/db") || true
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] NTB: ntb_test: modprobe on remote host
2016-12-28 0:12 [PATCH 1/2] NTB: ntb_test: modprobe on remote host Allen Hubbe
2016-12-28 0:12 ` [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask Allen Hubbe
@ 2016-12-28 0:16 ` Logan Gunthorpe
2017-01-10 21:51 ` Jon Mason
1 sibling, 1 reply; 6+ messages in thread
From: Logan Gunthorpe @ 2016-12-28 0:16 UTC (permalink / raw)
To: Allen Hubbe, linux-ntb; +Cc: Jon Mason
Looks good to me.
Acked-by: Logan Gunthorpe <logang@deltatee.com>
On 27/12/16 05:12 PM, Allen Hubbe wrote:
> Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>
> ---
> tools/testing/selftests/ntb/ntb_test.sh | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
> index a676d3eefefb..4e70e19255bc 100755
> --- a/tools/testing/selftests/ntb/ntb_test.sh
> +++ b/tools/testing/selftests/ntb/ntb_test.sh
> @@ -85,6 +85,10 @@ set -e
> function _modprobe()
> {
> modprobe "$@"
> +
> + if [[ "$REMOTE_HOST" != "" ]]; then
> + ssh "$REMOTE_HOST" modprobe "$@"
> + fi
> }
>
> function split_remote()
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] NTB: ntb_test: modprobe on remote host
2016-12-28 0:16 ` [PATCH 1/2] NTB: ntb_test: modprobe on remote host Logan Gunthorpe
@ 2017-01-10 21:51 ` Jon Mason
0 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2017-01-10 21:51 UTC (permalink / raw)
To: Logan Gunthorpe; +Cc: Allen Hubbe, linux-ntb
On Tue, Dec 27, 2016 at 05:16:22PM -0700, Logan Gunthorpe wrote:
> Looks good to me.
>
> Acked-by: Logan Gunthorpe <logang@deltatee.com>
>
> On 27/12/16 05:12 PM, Allen Hubbe wrote:
> > Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>
Applied to my ntb tree
Thanks,
Jon
> > ---
> > tools/testing/selftests/ntb/ntb_test.sh | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
> > index a676d3eefefb..4e70e19255bc 100755
> > --- a/tools/testing/selftests/ntb/ntb_test.sh
> > +++ b/tools/testing/selftests/ntb/ntb_test.sh
> > @@ -85,6 +85,10 @@ set -e
> > function _modprobe()
> > {
> > modprobe "$@"
> > +
> > + if [[ "$REMOTE_HOST" != "" ]]; then
> > + ssh "$REMOTE_HOST" modprobe "$@"
> > + fi
> > }
> >
> > function split_remote()
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-10 21:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-28 0:12 [PATCH 1/2] NTB: ntb_test: modprobe on remote host Allen Hubbe
2016-12-28 0:12 ` [PATCH 2/2] NTB: ntb_test: add parameter for doorbell bitmask Allen Hubbe
2016-12-28 0:17 ` Logan Gunthorpe
2017-01-10 21:45 ` Jon Mason
2016-12-28 0:16 ` [PATCH 1/2] NTB: ntb_test: modprobe on remote host Logan Gunthorpe
2017-01-10 21:51 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox