Smatch warnings

Smatch warnings

[Jon Mason]

FYI, I was using smatch when building the NTB code and saw the following
warnings.  If anyone is bored, feel free to address them.

Thanks,
Jon

---

  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  DESCEND  objtool
  CHK     include/generated/compile.h
  CHK     kernel/kheaders_data.tar.xz
  CHECK   drivers/gpu/drm/i915/display/intel_frontbuffer.c
  CC [M]  drivers/gpu/drm/i915/display/intel_frontbuffer.o
  LD [M]  drivers/gpu/drm/i915/i915.o
  CHECK   drivers/net/ntb_netdev.c
  CC [M]  drivers/net/ntb_netdev.o
  LD [M]  drivers/ntb/ntb.o
  CHECK   drivers/ntb/ntb_transport.c
drivers/ntb/ntb_transport.c:1336 ntb_transport_probe() warn: should '1 << qp_count' be a 64 bit type?
  CC [M]  drivers/ntb/ntb_transport.o
  CHECK   drivers/ntb/hw/amd/ntb_hw_amd.c
  CC [M]  drivers/ntb/hw/amd/ntb_hw_amd.o
  CHECK   drivers/ntb/hw/idt/ntb_hw_idt.c
drivers/ntb/hw/idt/ntb_hw_idt.c:2514 idt_init_dbgfs() warn: passing zero to 'PTR_ERR'
drivers/ntb/hw/idt/ntb_hw_idt.c:2760 idt_pci_probe() warn: passing zero to 'PTR_ERR'
  CC [M]  drivers/ntb/hw/idt/ntb_hw_idt.o
  CHECK   drivers/ntb/hw/intel/ntb_hw_gen1.c
  CC [M]  drivers/ntb/hw/intel/ntb_hw_gen1.o
  CHECK   drivers/ntb/hw/intel/ntb_hw_gen3.c
  CC [M]  drivers/ntb/hw/intel/ntb_hw_gen3.o
  CHECK   drivers/ntb/hw/intel/ntb_hw_gen4.c
  CC [M]  drivers/ntb/hw/intel/ntb_hw_gen4.o
  LD [M]  drivers/ntb/hw/intel/ntb_hw_intel.o
  CHECK   drivers/ntb/hw/mscc/ntb_hw_switchtec.c
  CC [M]  drivers/ntb/hw/mscc/ntb_hw_switchtec.o
  CHECK   drivers/ntb/test/ntb_pingpong.c
  CC [M]  drivers/ntb/test/ntb_pingpong.o
  CHECK   drivers/ntb/test/ntb_tool.c
drivers/ntb/test/ntb_tool.c:1288 tool_inmsg_read() error: uninitialized symbol 'pidx'.
  CC [M]  drivers/ntb/test/ntb_tool.o
  CHECK   drivers/ntb/test/ntb_perf.c
  CC [M]  drivers/ntb/test/ntb_perf.o
  CHECK   drivers/ntb/test/ntb_msi_test.c
  CC [M]  drivers/ntb/test/ntb_msi_test.o
Kernel: arch/x86/boot/bzImage is ready  (#6)
  MODPOST 7760 modules
  LD [M]  drivers/gpu/drm/i915/i915.ko
  CC [M]  drivers/net/ntb_netdev.mod.o
  LD [M]  drivers/net/ntb_netdev.ko
  CC [M]  drivers/ntb/hw/amd/ntb_hw_amd.mod.o
  LD [M]  drivers/ntb/hw/amd/ntb_hw_amd.ko
  CC [M]  drivers/ntb/hw/idt/ntb_hw_idt.mod.o
  LD [M]  drivers/ntb/hw/idt/ntb_hw_idt.ko
  CC [M]  drivers/ntb/hw/intel/ntb_hw_intel.mod.o
  LD [M]  drivers/ntb/hw/intel/ntb_hw_intel.ko
  CC [M]  drivers/ntb/hw/mscc/ntb_hw_switchtec.mod.o
  LD [M]  drivers/ntb/hw/mscc/ntb_hw_switchtec.ko
  CC [M]  drivers/ntb/ntb.mod.o
  LD [M]  drivers/ntb/ntb.ko
  CC [M]  drivers/ntb/ntb_transport.mod.o
  LD [M]  drivers/ntb/ntb_transport.ko
  CC [M]  drivers/ntb/test/ntb_msi_test.mod.o
  LD [M]  drivers/ntb/test/ntb_msi_test.ko
  CC [M]  drivers/ntb/test/ntb_perf.mod.o
  LD [M]  drivers/ntb/test/ntb_perf.ko
  CC [M]  drivers/ntb/test/ntb_pingpong.mod.o
  LD [M]  drivers/ntb/test/ntb_pingpong.ko
  CC [M]  drivers/ntb/test/ntb_tool.mod.o
  LD [M]  drivers/ntb/test/ntb_tool.ko