From: Kari Argillander <kari.argillander@gmail.com>
To: Enrico Mioso <mrkiko.rs@gmail.com>
Cc: ntfs3@lists.linux.dev
Subject: Re: [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty
Date: Tue, 26 Oct 2021 23:53:46 +0300 [thread overview]
Message-ID: <20211026205346.25g4snt7o3purff2@kari-VirtualBox> (raw)
In-Reply-To: <20211026204922.126100-1-mrkiko.rs@gmail.com>
On Tue, Oct 26, 2021 at 10:49:22PM +0200, Enrico Mioso wrote:
> We are actually marking the volume as dirty. Reflect this in the message.
Again this should look like below. Maybe send patch series which contains
both of your patches. Mark it as v2.
We are actually marking the volume as dirty. Reflect this in the
message.
I have not strong opinion about this change so I let Konstantin decide.
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> ---
> fs/ntfs3/fsntfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> index abe74dc9ce31..08802d7ca078 100644
> --- a/fs/ntfs3/fsntfs.c
> +++ b/fs/ntfs3/fsntfs.c
> @@ -933,7 +933,7 @@ int ntfs_set_state(struct ntfs_sb_info *sbi, enum NTFS_DIRTY_FLAGS dirty)
>
> switch (dirty) {
> case NTFS_DIRTY_ERROR:
> - ntfs_notice(sbi->sb, "Mark volume as dirty due to NTFS errors");
> + ntfs_notice(sbi->sb, "Marking volume as dirty due to NTFS errors");
> sbi->volume.real_dirty = true;
> fallthrough;
> case NTFS_DIRTY_DIRTY:
> --
> 2.33.1
>
>
next prev parent reply other threads:[~2021-10-26 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 20:49 [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty Enrico Mioso
2021-10-26 20:53 ` Kari Argillander [this message]
2021-10-26 20:56 ` Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026205346.25g4snt7o3purff2@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=mrkiko.rs@gmail.com \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox