* [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty
@ 2021-10-26 20:49 Enrico Mioso
2021-10-26 20:53 ` Kari Argillander
0 siblings, 1 reply; 3+ messages in thread
From: Enrico Mioso @ 2021-10-26 20:49 UTC (permalink / raw)
To: ntfs3; +Cc: Enrico Mioso
We are actually marking the volume as dirty. Reflect this in the message.
Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
---
fs/ntfs3/fsntfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
index abe74dc9ce31..08802d7ca078 100644
--- a/fs/ntfs3/fsntfs.c
+++ b/fs/ntfs3/fsntfs.c
@@ -933,7 +933,7 @@ int ntfs_set_state(struct ntfs_sb_info *sbi, enum NTFS_DIRTY_FLAGS dirty)
switch (dirty) {
case NTFS_DIRTY_ERROR:
- ntfs_notice(sbi->sb, "Mark volume as dirty due to NTFS errors");
+ ntfs_notice(sbi->sb, "Marking volume as dirty due to NTFS errors");
sbi->volume.real_dirty = true;
fallthrough;
case NTFS_DIRTY_DIRTY:
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty
2021-10-26 20:49 [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty Enrico Mioso
@ 2021-10-26 20:53 ` Kari Argillander
2021-10-26 20:56 ` Kari Argillander
0 siblings, 1 reply; 3+ messages in thread
From: Kari Argillander @ 2021-10-26 20:53 UTC (permalink / raw)
To: Enrico Mioso; +Cc: ntfs3
On Tue, Oct 26, 2021 at 10:49:22PM +0200, Enrico Mioso wrote:
> We are actually marking the volume as dirty. Reflect this in the message.
Again this should look like below. Maybe send patch series which contains
both of your patches. Mark it as v2.
We are actually marking the volume as dirty. Reflect this in the
message.
I have not strong opinion about this change so I let Konstantin decide.
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> ---
> fs/ntfs3/fsntfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> index abe74dc9ce31..08802d7ca078 100644
> --- a/fs/ntfs3/fsntfs.c
> +++ b/fs/ntfs3/fsntfs.c
> @@ -933,7 +933,7 @@ int ntfs_set_state(struct ntfs_sb_info *sbi, enum NTFS_DIRTY_FLAGS dirty)
>
> switch (dirty) {
> case NTFS_DIRTY_ERROR:
> - ntfs_notice(sbi->sb, "Mark volume as dirty due to NTFS errors");
> + ntfs_notice(sbi->sb, "Marking volume as dirty due to NTFS errors");
> sbi->volume.real_dirty = true;
> fallthrough;
> case NTFS_DIRTY_DIRTY:
> --
> 2.33.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty
2021-10-26 20:53 ` Kari Argillander
@ 2021-10-26 20:56 ` Kari Argillander
0 siblings, 0 replies; 3+ messages in thread
From: Kari Argillander @ 2021-10-26 20:56 UTC (permalink / raw)
To: Enrico Mioso; +Cc: ntfs3
On Tue, Oct 26, 2021 at 11:53:46PM +0300, Kari Argillander wrote:
> On Tue, Oct 26, 2021 at 10:49:22PM +0200, Enrico Mioso wrote:
> > We are actually marking the volume as dirty. Reflect this in the message.
>
> Again this should look like below. Maybe send patch series which contains
> both of your patches. Mark it as v2.
And please also cc linux-kernel@vger.kernel.org
And to: should be also
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
>
> We are actually marking the volume as dirty. Reflect this in the
> message.
>
> I have not strong opinion about this change so I let Konstantin decide.
>
> > Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> > ---
> > fs/ntfs3/fsntfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> > index abe74dc9ce31..08802d7ca078 100644
> > --- a/fs/ntfs3/fsntfs.c
> > +++ b/fs/ntfs3/fsntfs.c
> > @@ -933,7 +933,7 @@ int ntfs_set_state(struct ntfs_sb_info *sbi, enum NTFS_DIRTY_FLAGS dirty)
> >
> > switch (dirty) {
> > case NTFS_DIRTY_ERROR:
> > - ntfs_notice(sbi->sb, "Mark volume as dirty due to NTFS errors");
> > + ntfs_notice(sbi->sb, "Marking volume as dirty due to NTFS errors");
> > sbi->volume.real_dirty = true;
> > fallthrough;
> > case NTFS_DIRTY_DIRTY:
> > --
> > 2.33.1
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-26 20:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 20:49 [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty Enrico Mioso
2021-10-26 20:53 ` Kari Argillander
2021-10-26 20:56 ` Kari Argillander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox