From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] fs/ntfs3: Remove unused function wnd_bits
Date: Wed, 10 Aug 2022 19:17:11 +0300 [thread overview]
Message-ID: <8a3b479b-dedc-2a73-32fa-5c0440048b7d@paragon-software.com> (raw)
In-Reply-To: <20220721031841.24571-1-jiapeng.chong@linux.alibaba.com>
On 7/21/22 06:18, Jiapeng Chong wrote:
> Since the function wnd_bits is defined but not called in any file, it is
> a useless function, and we delete it in view of the brevity of the code.
>
> Remove some warnings found by running scripts/kernel-doc, which is
> caused by using 'make W=1'.
>
> fs/ntfs3/bitmap.c:54:19: warning: unused function 'wnd_bits' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/ntfs3/bitmap.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/ntfs3/bitmap.c b/fs/ntfs3/bitmap.c
> index e3b5680fd516..177c5bc53373 100644
> --- a/fs/ntfs3/bitmap.c
> +++ b/fs/ntfs3/bitmap.c
> @@ -51,11 +51,6 @@ void ntfs3_exit_bitmap(void)
> kmem_cache_destroy(ntfs_enode_cachep);
> }
>
> -static inline u32 wnd_bits(const struct wnd_bitmap *wnd, size_t i)
> -{
> - return i + 1 == wnd->nwnd ? wnd->bits_last : wnd->sb->s_blocksize * 8;
> -}
> -
> /*
> * wnd_scan
> *
Applied, thanks!
prev parent reply other threads:[~2022-08-10 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 3:18 [PATCH] fs/ntfs3: Remove unused function wnd_bits Jiapeng Chong
2022-08-10 16:17 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3b479b-dedc-2a73-32fa-5c0440048b7d@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox