* [PATCH] fs/ntfs3: Remove unused function wnd_bits
@ 2022-07-21 3:18 Jiapeng Chong
2022-08-10 16:17 ` Konstantin Komarov
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-07-21 3:18 UTC (permalink / raw)
To: almaz.alexandrovich; +Cc: ntfs3, linux-kernel, Jiapeng Chong, Abaci Robot
Since the function wnd_bits is defined but not called in any file, it is
a useless function, and we delete it in view of the brevity of the code.
Remove some warnings found by running scripts/kernel-doc, which is
caused by using 'make W=1'.
fs/ntfs3/bitmap.c:54:19: warning: unused function 'wnd_bits' [-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/ntfs3/bitmap.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/ntfs3/bitmap.c b/fs/ntfs3/bitmap.c
index e3b5680fd516..177c5bc53373 100644
--- a/fs/ntfs3/bitmap.c
+++ b/fs/ntfs3/bitmap.c
@@ -51,11 +51,6 @@ void ntfs3_exit_bitmap(void)
kmem_cache_destroy(ntfs_enode_cachep);
}
-static inline u32 wnd_bits(const struct wnd_bitmap *wnd, size_t i)
-{
- return i + 1 == wnd->nwnd ? wnd->bits_last : wnd->sb->s_blocksize * 8;
-}
-
/*
* wnd_scan
*
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs/ntfs3: Remove unused function wnd_bits
2022-07-21 3:18 [PATCH] fs/ntfs3: Remove unused function wnd_bits Jiapeng Chong
@ 2022-08-10 16:17 ` Konstantin Komarov
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2022-08-10 16:17 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: ntfs3, linux-kernel, Abaci Robot
On 7/21/22 06:18, Jiapeng Chong wrote:
> Since the function wnd_bits is defined but not called in any file, it is
> a useless function, and we delete it in view of the brevity of the code.
>
> Remove some warnings found by running scripts/kernel-doc, which is
> caused by using 'make W=1'.
>
> fs/ntfs3/bitmap.c:54:19: warning: unused function 'wnd_bits' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/ntfs3/bitmap.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/ntfs3/bitmap.c b/fs/ntfs3/bitmap.c
> index e3b5680fd516..177c5bc53373 100644
> --- a/fs/ntfs3/bitmap.c
> +++ b/fs/ntfs3/bitmap.c
> @@ -51,11 +51,6 @@ void ntfs3_exit_bitmap(void)
> kmem_cache_destroy(ntfs_enode_cachep);
> }
>
> -static inline u32 wnd_bits(const struct wnd_bitmap *wnd, size_t i)
> -{
> - return i + 1 == wnd->nwnd ? wnd->bits_last : wnd->sb->s_blocksize * 8;
> -}
> -
> /*
> * wnd_scan
> *
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-10 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-21 3:18 [PATCH] fs/ntfs3: Remove unused function wnd_bits Jiapeng Chong
2022-08-10 16:17 ` Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox