From: Tarun Sahu <tsahu@linux.ibm.com>
To: nvdimm@lists.linux.dev
Cc: tsahu@linux.ibm.com, dan.j.williams@intel.com,
vishal.l.verma@intel.com, aneesh.kumar@linux.ibm.com,
sbhat@linux.ibm.com, vaibhav@linux.ibm.com
Subject: [PATCH v4 2/2] ndctl/namespace: Implement write-infoblock for sector mode namespaces
Date: Fri, 27 May 2022 16:00:21 +0530 [thread overview]
Message-ID: <20220527103021.452651-3-tsahu@linux.ibm.com> (raw)
In-Reply-To: <20220527103021.452651-1-tsahu@linux.ibm.com>
While writing to the infoblock for sector mode, collected
namespace info in ns_info structure can be used to write the
original infoblock values except the ones that have been
provided by parameter arguments to write-infoblock command.
Currently, this patch allows only uuid and parent_uuid to be
changed. In future, support for other values can be implemented
easily by adding condition inside write_btt_sb() function, which
has been created to write BTT sector mode specific namespace.
$ ./ndctl read-infoblock namespace0.0 -j
[
{
"dev":"namespace0.0",
"signature":"BTT_ARENA_INFO",
"uuid":"7296ebd6-7039-4d02-9ed9-ac5f351ff0e4",
"parent_uuid":"46850d31-8fb5-4492-b630-9f3cd7b77500",
"flags":0,
"version":"2.0",
"external_lbasize":4096,
"external_nlba":8380160,
"internal_lbasize":4096,
"internal_nlba":8380416,
"nfree":256,
"infosize":4096,
"nextoff":0,
"dataoff":4096,
"mapoff":34326196224,
"logoff":34359717888,
"info2off":34359734272
}
]
read 1 infoblock
$ ./ndctl write-infoblock namespace0.0 \
> --uuid "d0b19883-0874-4847-8c71-71549590949c"
wrote 1 infoblock
$ ./ndctl read-infoblock namespace0.0 -j
[
{
"dev":"namespace0.0",
"signature":"BTT_ARENA_INFO",
"uuid":"d0b19883-0874-4847-8c71-71549590949c",
"parent_uuid":"46850d31-8fb5-4492-b630-9f3cd7b77500",
"flags":0,
"version":"2.0",
"external_lbasize":4096,
"external_nlba":8380160,
"internal_lbasize":4096,
"internal_nlba":8380416,
"nfree":256,
"infosize":4096,
"nextoff":0,
"dataoff":4096,
"mapoff":34326196224,
"logoff":34359717888,
"info2off":34359734272
}
]
read 1 infoblock
Signed-off-by: Tarun Sahu <tsahu@linux.ibm.com>
---
ndctl/namespace.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/ndctl/namespace.c b/ndctl/namespace.c
index e890fc2..2b0c821 100644
--- a/ndctl/namespace.c
+++ b/ndctl/namespace.c
@@ -253,6 +253,7 @@ static int set_defaults(enum device_action action)
break;
case NDCTL_NS_MODE_FSDAX:
case NDCTL_NS_MODE_DEVDAX:
+ case NDCTL_NS_MODE_SECTOR:
break;
default:
if (action == ACTION_WRITE_INFOBLOCK) {
@@ -2021,6 +2022,48 @@ static int write_pfn_sb(int fd, unsigned long long size, const char *sig,
return 0;
}
+static int write_btt_sb(const int fd, unsigned long long size, struct ns_info *ns_info)
+{
+ int rc = 0;
+ uuid_t uuid, parent_uuid;
+
+ // updating the original values which are asked to change,
+ // rest will be unchanged
+ if (param.uuid) {
+ rc = uuid_parse(param.uuid, uuid);
+ if (rc) {
+ error("Failed to parse UUID");
+ return rc;
+ }
+ memcpy(((struct btt_sb *)(ns_info->ns_sb_buf + ns_info->offset))->uuid,
+ uuid, sizeof(uuid_t));
+ }
+ if (param.parent_uuid) {
+ rc = uuid_parse(param.parent_uuid, parent_uuid);
+ if (rc) {
+ error("Failed to parse UUID");
+ return rc;
+ }
+ memcpy(((struct btt_sb *)(ns_info->ns_sb_buf + ns_info->offset))->parent_uuid,
+ parent_uuid, sizeof(uuid_t));
+ }
+
+ if (pwrite(fd, ns_info->ns_sb_buf + ns_info->offset, sizeof(struct btt_sb),
+ ns_info->offset) < 0) {
+ pr_verbose("Unable to write the info block: %s\n",
+ strerror(errno));
+ rc = -errno;
+ }
+
+ if (pwrite(fd, ns_info->ns_sb_buf + ns_info->offset, sizeof(struct btt_sb),
+ size - sizeof(struct btt_sb)) < 0) {
+ pr_verbose("Unable to write the info block: %s\n",
+ strerror(errno));
+ rc = -errno;
+ }
+ return rc;
+}
+
static int file_write_infoblock(const char *path, struct ns_info *ns_info)
{
unsigned long long size = parse_size64(param.size);
@@ -2068,6 +2111,14 @@ static int file_write_infoblock(const char *path, struct ns_info *ns_info)
case NDCTL_NS_MODE_DEVDAX:
rc = write_pfn_sb(fd, size, DAX_SIG, ns_info);
break;
+ case NDCTL_NS_MODE_SECTOR:
+ if (ns_info->mode == NDCTL_NS_MODE_SECTOR)
+ rc = write_btt_sb(fd, size, ns_info);
+ else {
+ pr_verbose("Conversion from non-sector to sector mode not allowed");
+ rc = -EPERM;
+ }
+ break;
case NDCTL_NS_MODE_UNKNOWN:
switch (ns_info->mode) {
case NDCTL_NS_MODE_FSDAX:
@@ -2076,6 +2127,9 @@ static int file_write_infoblock(const char *path, struct ns_info *ns_info)
case NDCTL_NS_MODE_DEVDAX:
rc = write_pfn_sb(fd, size, DAX_SIG, ns_info);
break;
+ case NDCTL_NS_MODE_SECTOR:
+ rc = write_btt_sb(fd, size, ns_info);
+ break;
default:
rc = -EINVAL;
break;
--
2.35.1
next prev parent reply other threads:[~2022-05-27 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 10:30 [PATCH v4 0/2]ndctl/namespace: Fix and improve write-infoblock Tarun Sahu
2022-05-27 10:30 ` [PATCH v4 1/2] ndctl/namespace: Fix multiple issues with write-infoblock Tarun Sahu
2022-05-27 10:30 ` Tarun Sahu [this message]
2022-06-20 9:27 ` [PATCH v4 0/2]ndctl/namespace: Fix and improve write-infoblock Tarun Sahu
2022-08-01 7:50 ` Tarun Sahu
2022-09-13 3:18 ` Verma, Vishal L
2022-09-13 10:26 ` Tarun Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527103021.452651-3-tsahu@linux.ibm.com \
--to=tsahu@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=nvdimm@lists.linux.dev \
--cc=sbhat@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox