NVDIMM Device and Persistent Memory development
 help / color / mirror / Atom feed
From: Tarun Sahu <tsahu@linux.ibm.com>
To: nvdimm@lists.linux.dev
Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com,
	aneesh.kumar@linux.ibm.com, sbhat@linux.ibm.com,
	vaibhav@linux.ibm.com
Subject: Re: [PATCH v4 0/2]ndctl/namespace: Fix and improve write-infoblock
Date: Mon, 01 Aug 2022 13:20:09 +0530	[thread overview]
Message-ID: <470ec99b8222dc5676a53cdb7dc5e19913221894.camel@linux.ibm.com> (raw)
In-Reply-To: <20220527103021.452651-1-tsahu@linux.ibm.com>

Hi, 

Just a gentle reminder. May you please look into these patches.
Please let me know if any changes are required.

Thanks
Tarun


On Fri, 2022-05-27 at 16:00 +0530, Tarun Sahu wrote:
> This series resolves some issues with write-infoblock 
> command and provide support to write-infoblock for sector 
> mode namespace
> 
> write-infoblock command has issues regarding updating the 
> align, uuid, parent_uuid. In case of no parameter passed 
> for it, this command used to overwrite the existing values 
> with defaults.
> 
> In PATCH 1/2 these parameters will be set to their original 
> values, incase, values hasn't been passed in command 
> arguments
> 
> write-infoblock command doesn't have support for sector/BTT 
> mode namespaces. They can be converted to fsdax, but can 
> not be written being in sector mode.
> 
> In PATCH 2/2, It creates a functionality which write 
> infoblock of Sector/BTT namespace. Currently only uuid, 
> parent_uuid can be updated. In future, Support for other 
> parameters can easily be integrated in the
> functionality.
> 
> ---
> v2:
>   Updated the commit message (rephrasing) in patch 1/2
>   Moved the ns_info struct to namespace.c from namespace.h
>   put the results after --- to avoid long commit message
> 
> v3:
>   reformat the commit message to meet 100 column condition
> 
> v4:
>   - Moved the struct ns_info definition to the beginning of
>   the block 
>   - Initialized the buf of ns_info structure in ns_info_init
>   - Change the format of comment in code from "//" to "/**/"
>   - reword the commit message of patch 2/2
> 
> Tarun Sahu (2):
>   ndctl/namespace: Fix multiple issues with write-infoblock
>   ndctl/namespace: Implement write-infoblock for sector mode
> namespaces
> 
>  ndctl/namespace.c | 314 ++++++++++++++++++++++++++++++++++----------
> --
>  1 file changed, 231 insertions(+), 83 deletions(-)
> 


  parent reply	other threads:[~2022-08-01  7:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 10:30 [PATCH v4 0/2]ndctl/namespace: Fix and improve write-infoblock Tarun Sahu
2022-05-27 10:30 ` [PATCH v4 1/2] ndctl/namespace: Fix multiple issues with write-infoblock Tarun Sahu
2022-05-27 10:30 ` [PATCH v4 2/2] ndctl/namespace: Implement write-infoblock for sector mode namespaces Tarun Sahu
2022-06-20  9:27 ` [PATCH v4 0/2]ndctl/namespace: Fix and improve write-infoblock Tarun Sahu
2022-08-01  7:50 ` Tarun Sahu [this message]
2022-09-13  3:18 ` Verma, Vishal L
2022-09-13 10:26   ` Tarun Sahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470ec99b8222dc5676a53cdb7dc5e19913221894.camel@linux.ibm.com \
    --to=tsahu@linux.ibm.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=sbhat@linux.ibm.com \
    --cc=vaibhav@linux.ibm.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox