NVDIMM Device and Persistent Memory development
 help / color / mirror / Atom feed
From: Vishal Verma <vishal.l.verma@intel.com>
To: nvdimm@lists.linux.dev
Cc: Dan Williams <dan.j.williams@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	linux-cxl@vger.kernel.org
Subject: [PATCH ndctl 2/2] meson.build: add a check argument to run_command
Date: Tue, 06 Dec 2022 15:46:24 -0700	[thread overview]
Message-ID: <20221206-vv-misc-v1-2-4c5bd58c90ca@intel.com> (raw)
In-Reply-To: <20221206-vv-misc-v1-0-4c5bd58c90ca@intel.com>

Meson has started to warn about:

  WARNING: You should add the boolean check kwarg to the run_command call.
         It currently defaults to false,
         but it will default to true in future releases of meson.
         See also: https://github.com/mesonbuild/meson/issues/9300

There is one instance of run_command() in the top-level meson.build
which elides the explicit check argument. Since we don't care about the
result of clean_config.sh (if any config.h are found they will be
cleaned, and if none are found, we're fine), add a 'check: false'
argument to this and squelch the warning.

Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index 20a646d..33ed0ed 100644
--- a/meson.build
+++ b/meson.build
@@ -89,6 +89,7 @@ env = find_program('env')
 if git.found()
   run_command('clean_config.sh',
     env : 'GIT_DIR=@0@/.git'.format(project_source_root),
+    check : false,
   )
 endif
 

-- 
2.38.1

  parent reply	other threads:[~2022-12-06 22:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 22:46 [PATCH ndctl 0/2] misc meson.build and clang-format updates Vishal Verma
2022-12-06 22:46 ` [PATCH ndctl 1/2] clang-format: Align consecutive macros and #defines Vishal Verma
2022-12-07  1:12   ` Alison Schofield
2022-12-06 22:46 ` Vishal Verma [this message]
2022-12-07 21:48   ` [PATCH ndctl 2/2] meson.build: add a check argument to run_command Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206-vv-misc-v1-2-4c5bd58c90ca@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox