From: Alison Schofield <alison.schofield@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: nvdimm@lists.linux.dev, Dan Williams <dan.j.williams@intel.com>,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH ndctl 1/2] clang-format: Align consecutive macros and #defines
Date: Tue, 6 Dec 2022 17:12:33 -0800 [thread overview]
Message-ID: <Y4/ogRA0SybTSQ0p@aschofie-mobl2> (raw)
In-Reply-To: <20221206-vv-misc-v1-1-4c5bd58c90ca@intel.com>
On Tue, Dec 06, 2022 at 03:46:23PM -0700, Vishal Verma wrote:
> Add AlignConsecutiveMacros: true so that blocks of consecutive #defines
> can be neatly aligned.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Reported-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
Thanks Vishal!
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> .clang-format | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.clang-format b/.clang-format
> index b6169e1..9ea49bf 100644
> --- a/.clang-format
> +++ b/.clang-format
> @@ -13,6 +13,7 @@ AccessModifierOffset: -4
> AlignAfterOpenBracket: Align
> AlignConsecutiveAssignments: false
> AlignConsecutiveDeclarations: false
> +AlignConsecutiveMacros: true
> #AlignEscapedNewlines: Left # Unknown to clang-format-4.0
> AlignOperands: true
> AlignTrailingComments: false
>
> --
> 2.38.1
next prev parent reply other threads:[~2022-12-07 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 22:46 [PATCH ndctl 0/2] misc meson.build and clang-format updates Vishal Verma
2022-12-06 22:46 ` [PATCH ndctl 1/2] clang-format: Align consecutive macros and #defines Vishal Verma
2022-12-07 1:12 ` Alison Schofield [this message]
2022-12-06 22:46 ` [PATCH ndctl 2/2] meson.build: add a check argument to run_command Vishal Verma
2022-12-07 21:48 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4/ogRA0SybTSQ0p@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox