From: Chaitanya Kulkarni <kch@nvidia.com>
To: <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
<dave.jiang@intel.com>, <ira.weiny@intel.com>
Cc: <hch@lst.de>, <nvdimm@lists.linux.dev>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT
Date: Mon, 31 Jul 2023 15:46:17 -0700 [thread overview]
Message-ID: <20230731224617.8665-2-kch@nvidia.com> (raw)
In-Reply-To: <20230731224617.8665-1-kch@nvidia.com>
Set the QUEUE_FLAG_NOWAIT. Following are the performance numbers with
io_uring fio engine for random read, note that device has been populated
fully with randwrite workload before taking these numbers :-
linux-block (pmem-nowait-on) # grep IOPS pmem*fio | column -t
pmem-nowait-off-1.fio: read: IOPS=3683k, BW=14.0GiB/s
pmem-nowait-off-2.fio: read: IOPS=3819k, BW=14.6GiB/s
pmem-nowait-off-3.fio: read: IOPS=3999k, BW=15.3GiB/s
pmem-nowait-on-1.fio: read: IOPS=5837k, BW=22.3GiB/s
pmem-nowait-on-2.fio: read: IOPS=5936k, BW=22.6GiB/s
pmem-nowait-on-3.fio: read: IOPS=5945k, BW=22.7GiB/s
linux-block (pmem-nowait-on) # grep cpu pmem*fio | column -t
pmem-nowait-off-1.fio: cpu : usr=7.09%, sys=29.65%, ctx=198742065
pmem-nowait-off-2.fio: cpu : usr=6.89%, sys=30.56%, ctx=205817652
pmem-nowait-off-3.fio: cpu : usr=6.86%, sys=30.94%, ctx=222627094
pmem-nowait-on-1.fio: cpu : usr=10.58%, sys=88.44%, ctx=27181
pmem-nowait-on-2.fio: cpu : usr=10.50%, sys=87.75%, ctx=25746
pmem-nowait-on-3.fio: cpu : usr=10.67%, sys=88.60%, ctx=28261
linux-block (pmem-nowait-on) # grep slat pmem*fio | column -t
pmem-nowait-off-1.fio: slat (nsec): min=432, max=50847k, avg=9324.69
pmem-nowait-off-2.fio: slat (nsec): min=441, max=52557k, avg=9132.45
pmem-nowait-off-3.fio: slat (nsec): min=430, max=36113k, avg=9132.63
pmem-nowait-on-1.fio: slat (nsec): min=1393, max=68090k, avg=7615.31
pmem-nowait-on-2.fio: slat (nsec): min=1222, max=44137k, avg=7493.77
pmem-nowait-on-3.fio: slat (nsec): min=1493, max=40100k, avg=7486.36
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvdimm/pmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 46e094e56159..ddd485c377eb 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -543,6 +543,7 @@ static int pmem_attach_disk(struct device *dev,
blk_queue_max_hw_sectors(q, UINT_MAX);
blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, q);
+ blk_queue_flag_set(QUEUE_FLAG_NOWAIT, q);
if (pmem->pfn_flags & PFN_MAP)
blk_queue_flag_set(QUEUE_FLAG_DAX, q);
--
2.40.0
next prev parent reply other threads:[~2023-07-31 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 22:46 [PATCH V2 0/1] pmem: set QUEUE_FLAG_NOWAIT Chaitanya Kulkarni
2023-07-31 22:46 ` Chaitanya Kulkarni [this message]
2023-08-01 15:23 ` [PATCH V2 1/1] " Jeff Moyer
2023-08-01 15:59 ` Christoph Hellwig
2023-08-01 17:49 ` Jeff Moyer
2023-08-02 1:25 ` Chaitanya Kulkarni
2023-08-02 12:30 ` Christoph Hellwig
2023-08-02 15:27 ` Jeff Moyer
2023-08-03 3:24 ` Chaitanya Kulkarni
2023-08-03 13:11 ` Jeff Moyer
2023-08-02 15:36 ` Jens Axboe
2023-08-02 16:25 ` Christoph Hellwig
2023-08-03 3:21 ` Chaitanya Kulkarni
2023-08-03 3:17 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731224617.8665-2-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox