From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jeff Moyer <jmoyer@redhat.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
"dave.jiang@intel.com" <dave.jiang@intel.com>,
"ira.weiny@intel.com" <ira.weiny@intel.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT
Date: Thu, 3 Aug 2023 03:17:38 +0000 [thread overview]
Message-ID: <a765facc-3991-41b3-6fe7-9fc5ee68e57e@nvidia.com> (raw)
In-Reply-To: <20230802123010.GB30792@lst.de>
On 8/2/23 05:30, Christoph Hellwig wrote:
> Given that pmem simply loops over an arbitrarily large bio I think
> we also need a threshold for which to allow nowait I/O. While it
> won't block for giant I/Os, doing all of them in the submitter
> context isn't exactly the idea behind the nowait I/O.
>
> I'm not really sure what a good theshold would be, though.
>
> Btw, please also always add linux-block to the Cc list for block
> driver patches that are even the slightest bit about the block
> layer interface.
will do ..
-ck
prev parent reply other threads:[~2023-08-03 3:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 22:46 [PATCH V2 0/1] pmem: set QUEUE_FLAG_NOWAIT Chaitanya Kulkarni
2023-07-31 22:46 ` [PATCH V2 1/1] " Chaitanya Kulkarni
2023-08-01 15:23 ` Jeff Moyer
2023-08-01 15:59 ` Christoph Hellwig
2023-08-01 17:49 ` Jeff Moyer
2023-08-02 1:25 ` Chaitanya Kulkarni
2023-08-02 12:30 ` Christoph Hellwig
2023-08-02 15:27 ` Jeff Moyer
2023-08-03 3:24 ` Chaitanya Kulkarni
2023-08-03 13:11 ` Jeff Moyer
2023-08-02 15:36 ` Jens Axboe
2023-08-02 16:25 ` Christoph Hellwig
2023-08-03 3:21 ` Chaitanya Kulkarni
2023-08-03 3:17 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a765facc-3991-41b3-6fe7-9fc5ee68e57e@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox