From: Dave Jiang <dave.jiang@intel.com>
To: Keith Busch <kbusch@meta.com>,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
nvdimm@lists.linux.dev
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] btt: fix block integrity
Date: Tue, 3 Sep 2024 08:47:48 -0700 [thread overview]
Message-ID: <588f9c7c-3c67-474f-a364-927d57bec130@intel.com> (raw)
In-Reply-To: <20240830204255.4130362-1-kbusch@meta.com>
On 8/30/24 1:42 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> bip is NULL before bio_integrity_prep().
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/nvdimm/btt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index 423dcd1909061..13594fb712186 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1435,8 +1435,8 @@ static int btt_do_bvec(struct btt *btt, struct bio_integrity_payload *bip,
>
> static void btt_submit_bio(struct bio *bio)
> {
> - struct bio_integrity_payload *bip = bio_integrity(bio);
> struct btt *btt = bio->bi_bdev->bd_disk->private_data;
> + struct bio_integrity_payload *bip;
> struct bvec_iter iter;
> unsigned long start;
> struct bio_vec bvec;
> @@ -1445,6 +1445,7 @@ static void btt_submit_bio(struct bio *bio)
>
> if (!bio_integrity_prep(bio))
> return;
> + bip = bio_integrity(bio);
>
> do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue);
> if (do_acct)
next prev parent reply other threads:[~2024-09-03 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 20:42 [PATCH] btt: fix block integrity Keith Busch
2024-09-03 15:47 ` Dave Jiang [this message]
2024-11-13 19:03 ` Ira Weiny
2024-11-13 19:21 ` Keith Busch
2024-11-13 21:28 ` Dan Williams
2024-11-13 21:50 ` Jeff Moyer
2024-11-13 22:06 ` Dan Williams
2024-11-14 4:22 ` Christoph Hellwig
2024-11-14 21:33 ` Verma, Vishal L
2024-11-15 15:19 ` Keith Busch
2024-11-15 17:58 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588f9c7c-3c67-474f-a364-927d57bec130@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox