From: Keith Busch <kbusch@kernel.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Keith Busch <kbusch@meta.com>,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, nvdimm@lists.linux.dev
Subject: Re: [PATCH] btt: fix block integrity
Date: Wed, 13 Nov 2024 12:21:31 -0700 [thread overview]
Message-ID: <ZzT8O_yvAVQDj2U6@kbusch-mbp> (raw)
In-Reply-To: <6734f81e4d5b9_214092294be@iweiny-mobl.notmuch>
On Wed, Nov 13, 2024 at 01:03:58PM -0600, Ira Weiny wrote:
> Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > bip is NULL before bio_integrity_prep().
>
> Did this fail in some way the user might see? How was this found?
I think this means no one ever used block integrity with btt. :)
I found this purely from code inspection because I was combing through
bio_integrity for a completely unrelated problem. I was trying to make
sense of how other drivers use it, and this one didn't make any.
> I think the code is correct but should this be backported to stable or
> anything?
Up to you! It's not fixing a regression since it appears to have never
worked before. You can also just delete support for it entirely if no
one cares to use this feature.
next prev parent reply other threads:[~2024-11-13 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 20:42 [PATCH] btt: fix block integrity Keith Busch
2024-09-03 15:47 ` Dave Jiang
2024-11-13 19:03 ` Ira Weiny
2024-11-13 19:21 ` Keith Busch [this message]
2024-11-13 21:28 ` Dan Williams
2024-11-13 21:50 ` Jeff Moyer
2024-11-13 22:06 ` Dan Williams
2024-11-14 4:22 ` Christoph Hellwig
2024-11-14 21:33 ` Verma, Vishal L
2024-11-15 15:19 ` Keith Busch
2024-11-15 17:58 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzT8O_yvAVQDj2U6@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=kbusch@meta.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).