From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Schofield, Alison" <alison.schofield@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [ndctl PATCH v2 04/18] ndctl/clang-format: Fix space after for_each macros
Date: Mon, 12 Dec 2022 18:16:02 +0000 [thread overview]
Message-ID: <5f1d9bc6ce1b4a7a41bf4b487e4b15eb4088cc9c.camel@intel.com> (raw)
In-Reply-To: <Y5Nu0wD/6I29aUqN@aschofie-mobl2>
On Fri, 2022-12-09 at 09:22 -0800, Alison Schofield wrote:
> On Thu, Dec 08, 2022 at 01:28:21PM -0800, Dan Williams wrote:
> > Copy the approach taken in the kernel via:
> >
> > commit 781121a7f6d1 ("clang-format: Fix space after for_each
> > macros")
>
> On a related note - 'cxl_mapping_foreach' seems to be missing from
> .clang-format. Perhaps it is in another patch I haven't seen yet.
Ah good catch - I think that's my miss - I'll send out a patch for that
separately.
>
> This patch -
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> >
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> > .clang-format | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/.clang-format b/.clang-format
> > index f372823c3248..448b7e7211ae 100644
> > --- a/.clang-format
> > +++ b/.clang-format
> > @@ -1,6 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0
> > #
> > -# clang-format configuration file. Intended for clang-format >= 6.
> > +# clang-format configuration file. Intended for clang-format >= 11.
> > # Copied from Linux's .clang-format
> > #
> > # For more information, see:
> > @@ -157,7 +157,7 @@ SpaceAfterTemplateKeyword: true
> > SpaceBeforeAssignmentOperators: true
> > SpaceBeforeCtorInitializerColon: true
> > SpaceBeforeInheritanceColon: true
> > -SpaceBeforeParens: ControlStatements
> > +SpaceBeforeParens: ControlStatementsExceptForEachMacros
> > SpaceBeforeRangeBasedForLoopColon: true
> > SpaceInEmptyParentheses: false
> > SpacesBeforeTrailingComments: 1
> >
next prev parent reply other threads:[~2022-12-12 18:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 21:27 [ndctl PATCH v2 00/18] cxl-cli test and usability updates Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 01/18] ndctl/test: Move firmware-update.sh to the 'destructive' set Dan Williams
2022-12-09 17:13 ` Alison Schofield
2022-12-08 21:28 ` [ndctl PATCH v2 02/18] ndctl/test: Add kernel backtrace detection to some dax tests Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 03/18] ndctl/clang-format: Move minimum version to 6 Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 04/18] ndctl/clang-format: Fix space after for_each macros Dan Williams
2022-12-09 17:22 ` Alison Schofield
2022-12-12 18:16 ` Verma, Vishal L [this message]
2022-12-08 21:28 ` [ndctl PATCH v2 05/18] cxl/list: Always attempt to collect child objects Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 06/18] cxl/list: Add a 'firmware_node' alias Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 07/18] cxl/list: Add parent_dport attribute to port listings Dan Williams
2022-12-17 1:36 ` Dan Williams
2023-01-04 20:15 ` Verma, Vishal L
2022-12-08 21:28 ` [ndctl PATCH v2 08/18] cxl/list: Skip emitting pmem_size when it is zero Dan Williams
2022-12-09 17:26 ` Alison Schofield
2022-12-08 21:28 ` [ndctl PATCH v2 09/18] cxl/filter: Return json-c topology Dan Williams
2022-12-09 17:27 ` Alison Schofield
2022-12-08 21:28 ` [ndctl PATCH v2 10/18] cxl/list: Record cxl objects in json objects Dan Williams
2022-12-09 17:28 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 11/18] cxl/region: Make ways an integer argument Dan Williams
2022-12-09 17:29 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 12/18] cxl/region: Make granularity " Dan Williams
2022-12-09 17:30 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 13/18] cxl/region: Use cxl_filter_walk() to gather create-region targets Dan Williams
2022-12-08 21:29 ` [ndctl PATCH v2 14/18] cxl/region: Trim region size by max available extent Dan Williams
2022-12-09 17:31 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 15/18] cxl/Documentation: Fix whitespace typos in create-region man page Dan Williams
2022-12-09 17:33 ` Alison Schofield
2022-12-09 18:06 ` Dan Williams
2022-12-13 21:17 ` Verma, Vishal L
2022-12-08 21:29 ` [ndctl PATCH v2 16/18] cxl/region: Autoselect memdevs for create-region Dan Williams
2022-12-09 4:08 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 17/18] cxl/test: Extend cxl-topology.sh for a single root-port host-bridge Dan Williams
2022-12-08 21:29 ` [ndctl PATCH v2 18/18] cxl/test: Test single-port host-bridge region creation Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f1d9bc6ce1b4a7a41bf4b487e4b15eb4088cc9c.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox