From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, Yi Zhang <yi.zhang@redhat.com>,
vishal.l.verma@intel.com, nvdimm@lists.linux.dev
Subject: Re: [ndctl PATCH v2 01/18] ndctl/test: Move firmware-update.sh to the 'destructive' set
Date: Fri, 9 Dec 2022 09:13:40 -0800 [thread overview]
Message-ID: <Y5NsxBeoL5nxSdAI@aschofie-mobl2> (raw)
In-Reply-To: <167053488383.582963.12851797514973259163.stgit@dwillia2-xfh.jf.intel.com>
On Thu, Dec 08, 2022 at 01:28:03PM -0800, Dan Williams wrote:
> The firmware update test attempts a system-suspend test which may break
> systems that have a broken driver, or otherwise are not prepared to support
> suspend.
>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> Link: https://github.com/pmem/ndctl/issues/221
> Reported-by: Yi Zhang <yi.zhang@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> test/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/meson.build b/test/meson.build
> index 5953c286d13f..c31d8eac66c5 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -170,7 +170,6 @@ tests = [
> [ 'btt-errors.sh', btt_errors, 'ndctl' ],
> [ 'hugetlb', hugetlb, 'ndctl' ],
> [ 'btt-pad-compat.sh', btt_pad_compat, 'ndctl' ],
> - [ 'firmware-update.sh', firmware_update, 'ndctl' ],
> [ 'ack-shutdown-count-set', ack_shutdown_count, 'ndctl' ],
> [ 'rescan-partitions.sh', rescan_partitions, 'ndctl' ],
> [ 'inject-smart.sh', inject_smart, 'ndctl' ],
> @@ -196,6 +195,7 @@ if get_option('destructive').enabled()
> mmap_test = find_program('mmap.sh')
>
> tests += [
> + [ 'firmware-update.sh', firmware_update, 'ndctl' ],
> [ 'pmem-ns', pmem_ns, 'ndctl' ],
> [ 'sub-section.sh', sub_section, 'dax' ],
> [ 'dax-dev', dax_dev, 'dax' ],
>
next prev parent reply other threads:[~2022-12-09 17:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 21:27 [ndctl PATCH v2 00/18] cxl-cli test and usability updates Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 01/18] ndctl/test: Move firmware-update.sh to the 'destructive' set Dan Williams
2022-12-09 17:13 ` Alison Schofield [this message]
2022-12-08 21:28 ` [ndctl PATCH v2 02/18] ndctl/test: Add kernel backtrace detection to some dax tests Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 03/18] ndctl/clang-format: Move minimum version to 6 Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 04/18] ndctl/clang-format: Fix space after for_each macros Dan Williams
2022-12-09 17:22 ` Alison Schofield
2022-12-12 18:16 ` Verma, Vishal L
2022-12-08 21:28 ` [ndctl PATCH v2 05/18] cxl/list: Always attempt to collect child objects Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 06/18] cxl/list: Add a 'firmware_node' alias Dan Williams
2022-12-08 21:28 ` [ndctl PATCH v2 07/18] cxl/list: Add parent_dport attribute to port listings Dan Williams
2022-12-17 1:36 ` Dan Williams
2023-01-04 20:15 ` Verma, Vishal L
2022-12-08 21:28 ` [ndctl PATCH v2 08/18] cxl/list: Skip emitting pmem_size when it is zero Dan Williams
2022-12-09 17:26 ` Alison Schofield
2022-12-08 21:28 ` [ndctl PATCH v2 09/18] cxl/filter: Return json-c topology Dan Williams
2022-12-09 17:27 ` Alison Schofield
2022-12-08 21:28 ` [ndctl PATCH v2 10/18] cxl/list: Record cxl objects in json objects Dan Williams
2022-12-09 17:28 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 11/18] cxl/region: Make ways an integer argument Dan Williams
2022-12-09 17:29 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 12/18] cxl/region: Make granularity " Dan Williams
2022-12-09 17:30 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 13/18] cxl/region: Use cxl_filter_walk() to gather create-region targets Dan Williams
2022-12-08 21:29 ` [ndctl PATCH v2 14/18] cxl/region: Trim region size by max available extent Dan Williams
2022-12-09 17:31 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 15/18] cxl/Documentation: Fix whitespace typos in create-region man page Dan Williams
2022-12-09 17:33 ` Alison Schofield
2022-12-09 18:06 ` Dan Williams
2022-12-13 21:17 ` Verma, Vishal L
2022-12-08 21:29 ` [ndctl PATCH v2 16/18] cxl/region: Autoselect memdevs for create-region Dan Williams
2022-12-09 4:08 ` Alison Schofield
2022-12-08 21:29 ` [ndctl PATCH v2 17/18] cxl/test: Extend cxl-topology.sh for a single root-port host-bridge Dan Williams
2022-12-08 21:29 ` [ndctl PATCH v2 18/18] cxl/test: Test single-port host-bridge region creation Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5NsxBeoL5nxSdAI@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox