* Delivery by get send-email to mailing list fails
[not found] <20220310120531.4942-1-msuchanek@suse.de>
@ 2022-03-10 12:17 ` Michal Suchánek
2022-03-10 12:54 ` Delivery by git " Michal Suchánek
0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchánek @ 2022-03-10 12:17 UTC (permalink / raw)
To: nvdimm
Hello,
I cannot send mail to the mailing list with get send-email.
The copy sent to me is delivered but the e-mail does not appear in the
mailing list archives.
Is there any way to fix this?
Thanks
Michal
On Thu, Mar 10, 2022 at 01:05:33PM +0100, Michal Suchanek wrote:
> With seed namespaces caught early on with
> commit 9bd2994 ("ndctl/namespace: Skip seed namespaces when processing all namespaces.")
> commit 07011a3 ("ndctl/namespace: Suppress -ENXIO when processing all namespaces.")
> the function-specific checks are no longer needed and can be dropped.
>
> Reverts commit fb13dfb ("zero_info_block: skip seed devices")
> Reverts commit fe626a8 ("ndctl/namespace: Fix disable-namespace accounting relative to seed devices")
>
> Fixes: 80e0d88 ("namespace-action: Drop zero namespace checks.")
> Fixes: fb13dfb ("zero_info_block: skip seed devices")
> Fixes: fe626a8 ("ndctl/namespace: Fix disable-namespace accounting relative to seed devices")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> ndctl/lib/libndctl.c | 7 +------
> ndctl/namespace.c | 11 ++++-------
> ndctl/region.c | 2 +-
> 3 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> index ccca8b5..110d8a5 100644
> --- a/ndctl/lib/libndctl.c
> +++ b/ndctl/lib/libndctl.c
> @@ -4593,7 +4593,6 @@ NDCTL_EXPORT int ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> const char *bdev = NULL;
> int fd, active = 0;
> char path[50];
> - unsigned long long size = ndctl_namespace_get_size(ndns);
>
> if (pfn && ndctl_pfn_is_enabled(pfn))
> bdev = ndctl_pfn_get_block_device(pfn);
> @@ -4630,11 +4629,7 @@ NDCTL_EXPORT int ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> devname);
> return -EBUSY;
> } else {
> - if (size == 0)
> - /* No disable necessary due to no capacity allocated */
> - return 1;
> - else
> - ndctl_namespace_disable_invalidate(ndns);
> + ndctl_namespace_disable_invalidate(ndns);
> }
>
> return 0;
> diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> index 257b58c..722f13a 100644
> --- a/ndctl/namespace.c
> +++ b/ndctl/namespace.c
> @@ -1054,9 +1054,6 @@ static int zero_info_block(struct ndctl_namespace *ndns)
> void *buf = NULL, *read_buf = NULL;
> char path[50];
>
> - if (ndctl_namespace_get_size(ndns) == 0)
> - return 1;
> -
> ndctl_namespace_set_raw_mode(ndns, 1);
> rc = ndctl_namespace_enable(ndns);
> if (rc < 0) {
> @@ -1130,7 +1127,7 @@ static int namespace_prep_reconfig(struct ndctl_region *region,
> }
>
> rc = ndctl_namespace_disable_safe(ndns);
> - if (rc < 0)
> + if (rc)
> return rc;
>
> ndctl_namespace_set_enforce_mode(ndns, NDCTL_NS_MODE_RAW);
> @@ -1426,7 +1423,7 @@ static int dax_clear_badblocks(struct ndctl_dax *dax)
> return -ENXIO;
>
> rc = ndctl_namespace_disable_safe(ndns);
> - if (rc < 0) {
> + if (rc) {
> error("%s: unable to disable namespace: %s\n", devname,
> strerror(-rc));
> return rc;
> @@ -1450,7 +1447,7 @@ static int pfn_clear_badblocks(struct ndctl_pfn *pfn)
> return -ENXIO;
>
> rc = ndctl_namespace_disable_safe(ndns);
> - if (rc < 0) {
> + if (rc) {
> error("%s: unable to disable namespace: %s\n", devname,
> strerror(-rc));
> return rc;
> @@ -1473,7 +1470,7 @@ static int raw_clear_badblocks(struct ndctl_namespace *ndns)
> return -ENXIO;
>
> rc = ndctl_namespace_disable_safe(ndns);
> - if (rc < 0) {
> + if (rc) {
> error("%s: unable to disable namespace: %s\n", devname,
> strerror(-rc));
> return rc;
> diff --git a/ndctl/region.c b/ndctl/region.c
> index e499546..33828b0 100644
> --- a/ndctl/region.c
> +++ b/ndctl/region.c
> @@ -71,7 +71,7 @@ static int region_action(struct ndctl_region *region, enum device_action mode)
> case ACTION_DISABLE:
> ndctl_namespace_foreach(region, ndns) {
> rc = ndctl_namespace_disable_safe(ndns);
> - if (rc < 0)
> + if (rc)
> return rc;
> }
> rc = ndctl_region_disable_invalidate(region);
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Delivery by git send-email to mailing list fails
2022-03-10 12:17 ` Delivery by get send-email to mailing list fails Michal Suchánek
@ 2022-03-10 12:54 ` Michal Suchánek
2022-03-10 13:29 ` Michal Suchánek
0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchánek @ 2022-03-10 12:54 UTC (permalink / raw)
To: nvdimm
On Thu, Mar 10, 2022 at 01:17:35PM +0100, Michal Suchánek wrote:
> Hello,
>
> I cannot send mail to the mailing list with get send-email.
>
> The copy sent to me is delivered but the e-mail does not appear in the
> mailing list archives.
>
> Is there any way to fix this?
Apparently the list is subscriber-only. This is unusual for mailing
lists related to kernel development, and is not documented.
Please update the documentation or the mailing list settings.
>
> Thanks
>
> Michal
>
> On Thu, Mar 10, 2022 at 01:05:33PM +0100, Michal Suchanek wrote:
> > With seed namespaces caught early on with
> > commit 9bd2994 ("ndctl/namespace: Skip seed namespaces when processing all namespaces.")
> > commit 07011a3 ("ndctl/namespace: Suppress -ENXIO when processing all namespaces.")
> > the function-specific checks are no longer needed and can be dropped.
> >
> > Reverts commit fb13dfb ("zero_info_block: skip seed devices")
> > Reverts commit fe626a8 ("ndctl/namespace: Fix disable-namespace accounting relative to seed devices")
> >
> > Fixes: 80e0d88 ("namespace-action: Drop zero namespace checks.")
> > Fixes: fb13dfb ("zero_info_block: skip seed devices")
> > Fixes: fe626a8 ("ndctl/namespace: Fix disable-namespace accounting relative to seed devices")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> > ndctl/lib/libndctl.c | 7 +------
> > ndctl/namespace.c | 11 ++++-------
> > ndctl/region.c | 2 +-
> > 3 files changed, 6 insertions(+), 14 deletions(-)
> >
> > diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> > index ccca8b5..110d8a5 100644
> > --- a/ndctl/lib/libndctl.c
> > +++ b/ndctl/lib/libndctl.c
> > @@ -4593,7 +4593,6 @@ NDCTL_EXPORT int ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> > const char *bdev = NULL;
> > int fd, active = 0;
> > char path[50];
> > - unsigned long long size = ndctl_namespace_get_size(ndns);
> >
> > if (pfn && ndctl_pfn_is_enabled(pfn))
> > bdev = ndctl_pfn_get_block_device(pfn);
> > @@ -4630,11 +4629,7 @@ NDCTL_EXPORT int ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> > devname);
> > return -EBUSY;
> > } else {
> > - if (size == 0)
> > - /* No disable necessary due to no capacity allocated */
> > - return 1;
> > - else
> > - ndctl_namespace_disable_invalidate(ndns);
> > + ndctl_namespace_disable_invalidate(ndns);
> > }
> >
> > return 0;
> > diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> > index 257b58c..722f13a 100644
> > --- a/ndctl/namespace.c
> > +++ b/ndctl/namespace.c
> > @@ -1054,9 +1054,6 @@ static int zero_info_block(struct ndctl_namespace *ndns)
> > void *buf = NULL, *read_buf = NULL;
> > char path[50];
> >
> > - if (ndctl_namespace_get_size(ndns) == 0)
> > - return 1;
> > -
> > ndctl_namespace_set_raw_mode(ndns, 1);
> > rc = ndctl_namespace_enable(ndns);
> > if (rc < 0) {
> > @@ -1130,7 +1127,7 @@ static int namespace_prep_reconfig(struct ndctl_region *region,
> > }
> >
> > rc = ndctl_namespace_disable_safe(ndns);
> > - if (rc < 0)
> > + if (rc)
> > return rc;
> >
> > ndctl_namespace_set_enforce_mode(ndns, NDCTL_NS_MODE_RAW);
> > @@ -1426,7 +1423,7 @@ static int dax_clear_badblocks(struct ndctl_dax *dax)
> > return -ENXIO;
> >
> > rc = ndctl_namespace_disable_safe(ndns);
> > - if (rc < 0) {
> > + if (rc) {
> > error("%s: unable to disable namespace: %s\n", devname,
> > strerror(-rc));
> > return rc;
> > @@ -1450,7 +1447,7 @@ static int pfn_clear_badblocks(struct ndctl_pfn *pfn)
> > return -ENXIO;
> >
> > rc = ndctl_namespace_disable_safe(ndns);
> > - if (rc < 0) {
> > + if (rc) {
> > error("%s: unable to disable namespace: %s\n", devname,
> > strerror(-rc));
> > return rc;
> > @@ -1473,7 +1470,7 @@ static int raw_clear_badblocks(struct ndctl_namespace *ndns)
> > return -ENXIO;
> >
> > rc = ndctl_namespace_disable_safe(ndns);
> > - if (rc < 0) {
> > + if (rc) {
> > error("%s: unable to disable namespace: %s\n", devname,
> > strerror(-rc));
> > return rc;
> > diff --git a/ndctl/region.c b/ndctl/region.c
> > index e499546..33828b0 100644
> > --- a/ndctl/region.c
> > +++ b/ndctl/region.c
> > @@ -71,7 +71,7 @@ static int region_action(struct ndctl_region *region, enum device_action mode)
> > case ACTION_DISABLE:
> > ndctl_namespace_foreach(region, ndns) {
> > rc = ndctl_namespace_disable_safe(ndns);
> > - if (rc < 0)
> > + if (rc)
> > return rc;
> > }
> > rc = ndctl_region_disable_invalidate(region);
> > --
> > 2.35.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Delivery by git send-email to mailing list fails
2022-03-10 12:54 ` Delivery by git " Michal Suchánek
@ 2022-03-10 13:29 ` Michal Suchánek
2022-03-10 18:47 ` Verma, Vishal L
0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchánek @ 2022-03-10 13:29 UTC (permalink / raw)
To: nvdimm
On Thu, Mar 10, 2022 at 01:54:36PM +0100, Michal Suchánek wrote:
> On Thu, Mar 10, 2022 at 01:17:35PM +0100, Michal Suchánek wrote:
> > Hello,
> >
> > I cannot send mail to the mailing list with get send-email.
> >
> > The copy sent to me is delivered but the e-mail does not appear in the
> > mailing list archives.
> >
> > Is there any way to fix this?
>
> Apparently the list is subscriber-only. This is unusual for mailing
> lists related to kernel development, and is not documented.
Actually, this has nothing to do with subscription. So in the end I have
no idea why e-mail sent by git send-email is not delivered to the list
while e-mail authored in a MUA works fine.
>
> Please update the documentation or the mailing list settings.
>
> >
> > Thanks
> >
> > Michal
> >
> > On Thu, Mar 10, 2022 at 01:05:33PM +0100, Michal Suchanek wrote:
> > > With seed namespaces caught early on with
> > > commit 9bd2994 ("ndctl/namespace: Skip seed namespaces when processing all namespaces.")
> > > commit 07011a3 ("ndctl/namespace: Suppress -ENXIO when processing all namespaces.")
> > > the function-specific checks are no longer needed and can be dropped.
> > >
> > > Reverts commit fb13dfb ("zero_info_block: skip seed devices")
> > > Reverts commit fe626a8 ("ndctl/namespace: Fix disable-namespace accounting relative to seed devices")
> > >
> > > Fixes: 80e0d88 ("namespace-action: Drop zero namespace checks.")
> > > Fixes: fb13dfb ("zero_info_block: skip seed devices")
> > > Fixes: fe626a8 ("ndctl/namespace: Fix disable-namespace accounting relative to seed devices")
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > > ---
> > > ndctl/lib/libndctl.c | 7 +------
> > > ndctl/namespace.c | 11 ++++-------
> > > ndctl/region.c | 2 +-
> > > 3 files changed, 6 insertions(+), 14 deletions(-)
> > >
> > > diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> > > index ccca8b5..110d8a5 100644
> > > --- a/ndctl/lib/libndctl.c
> > > +++ b/ndctl/lib/libndctl.c
> > > @@ -4593,7 +4593,6 @@ NDCTL_EXPORT int ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> > > const char *bdev = NULL;
> > > int fd, active = 0;
> > > char path[50];
> > > - unsigned long long size = ndctl_namespace_get_size(ndns);
> > >
> > > if (pfn && ndctl_pfn_is_enabled(pfn))
> > > bdev = ndctl_pfn_get_block_device(pfn);
> > > @@ -4630,11 +4629,7 @@ NDCTL_EXPORT int ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> > > devname);
> > > return -EBUSY;
> > > } else {
> > > - if (size == 0)
> > > - /* No disable necessary due to no capacity allocated */
> > > - return 1;
> > > - else
> > > - ndctl_namespace_disable_invalidate(ndns);
> > > + ndctl_namespace_disable_invalidate(ndns);
> > > }
> > >
> > > return 0;
> > > diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> > > index 257b58c..722f13a 100644
> > > --- a/ndctl/namespace.c
> > > +++ b/ndctl/namespace.c
> > > @@ -1054,9 +1054,6 @@ static int zero_info_block(struct ndctl_namespace *ndns)
> > > void *buf = NULL, *read_buf = NULL;
> > > char path[50];
> > >
> > > - if (ndctl_namespace_get_size(ndns) == 0)
> > > - return 1;
> > > -
> > > ndctl_namespace_set_raw_mode(ndns, 1);
> > > rc = ndctl_namespace_enable(ndns);
> > > if (rc < 0) {
> > > @@ -1130,7 +1127,7 @@ static int namespace_prep_reconfig(struct ndctl_region *region,
> > > }
> > >
> > > rc = ndctl_namespace_disable_safe(ndns);
> > > - if (rc < 0)
> > > + if (rc)
> > > return rc;
> > >
> > > ndctl_namespace_set_enforce_mode(ndns, NDCTL_NS_MODE_RAW);
> > > @@ -1426,7 +1423,7 @@ static int dax_clear_badblocks(struct ndctl_dax *dax)
> > > return -ENXIO;
> > >
> > > rc = ndctl_namespace_disable_safe(ndns);
> > > - if (rc < 0) {
> > > + if (rc) {
> > > error("%s: unable to disable namespace: %s\n", devname,
> > > strerror(-rc));
> > > return rc;
> > > @@ -1450,7 +1447,7 @@ static int pfn_clear_badblocks(struct ndctl_pfn *pfn)
> > > return -ENXIO;
> > >
> > > rc = ndctl_namespace_disable_safe(ndns);
> > > - if (rc < 0) {
> > > + if (rc) {
> > > error("%s: unable to disable namespace: %s\n", devname,
> > > strerror(-rc));
> > > return rc;
> > > @@ -1473,7 +1470,7 @@ static int raw_clear_badblocks(struct ndctl_namespace *ndns)
> > > return -ENXIO;
> > >
> > > rc = ndctl_namespace_disable_safe(ndns);
> > > - if (rc < 0) {
> > > + if (rc) {
> > > error("%s: unable to disable namespace: %s\n", devname,
> > > strerror(-rc));
> > > return rc;
> > > diff --git a/ndctl/region.c b/ndctl/region.c
> > > index e499546..33828b0 100644
> > > --- a/ndctl/region.c
> > > +++ b/ndctl/region.c
> > > @@ -71,7 +71,7 @@ static int region_action(struct ndctl_region *region, enum device_action mode)
> > > case ACTION_DISABLE:
> > > ndctl_namespace_foreach(region, ndns) {
> > > rc = ndctl_namespace_disable_safe(ndns);
> > > - if (rc < 0)
> > > + if (rc)
> > > return rc;
> > > }
> > > rc = ndctl_region_disable_invalidate(region);
> > > --
> > > 2.35.1
> > >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Delivery by git send-email to mailing list fails
2022-03-10 13:29 ` Michal Suchánek
@ 2022-03-10 18:47 ` Verma, Vishal L
0 siblings, 0 replies; 4+ messages in thread
From: Verma, Vishal L @ 2022-03-10 18:47 UTC (permalink / raw)
To: nvdimm@lists.linux.dev, msuchanek@suse.de
On Thu, 2022-03-10 at 14:29 +0100, Michal Suchánek wrote:
> On Thu, Mar 10, 2022 at 01:54:36PM +0100, Michal Suchánek wrote:
> > On Thu, Mar 10, 2022 at 01:17:35PM +0100, Michal Suchánek wrote:
> > > Hello,
> > >
> > > I cannot send mail to the mailing list with get send-email.
> > >
> > > The copy sent to me is delivered but the e-mail does not appear
> > > in the
> > > mailing list archives.
> > >
> > > Is there any way to fix this?
> >
> > Apparently the list is subscriber-only. This is unusual for mailing
> > lists related to kernel development, and is not documented.
>
> Actually, this has nothing to do with subscription. So in the end I
> have
> no idea why e-mail sent by git send-email is not delivered to the
> list
> while e-mail authored in a MUA works fine.
Michal,
It looks like your patches from today (I see three) did make it to the
list. e.g.:
https://lore.kernel.org/nvdimm/20220310133106.GA106734@kunlun.suse.cz/T/#u
Did you change something on your end?
>
> >
> > Please update the documentation or the mailing list settings.
> >
> > >
> > > Thanks
> > >
> > > Michal
> > >
> > > On Thu, Mar 10, 2022 at 01:05:33PM +0100, Michal Suchanek wrote:
> > > > With seed namespaces caught early on with
> > > > commit 9bd2994 ("ndctl/namespace: Skip seed namespaces when
> > > > processing all namespaces.")
> > > > commit 07011a3 ("ndctl/namespace: Suppress -ENXIO when
> > > > processing all namespaces.")
> > > > the function-specific checks are no longer needed and can be
> > > > dropped.
> > > >
> > > > Reverts commit fb13dfb ("zero_info_block: skip seed devices")
> > > > Reverts commit fe626a8 ("ndctl/namespace: Fix disable-namespace
> > > > accounting relative to seed devices")
> > > >
> > > > Fixes: 80e0d88 ("namespace-action: Drop zero namespace
> > > > checks.")
> > > > Fixes: fb13dfb ("zero_info_block: skip seed devices")
> > > > Fixes: fe626a8 ("ndctl/namespace: Fix disable-namespace
> > > > accounting relative to seed devices")
> > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > > > ---
> > > > ndctl/lib/libndctl.c | 7 +------
> > > > ndctl/namespace.c | 11 ++++-------
> > > > ndctl/region.c | 2 +-
> > > > 3 files changed, 6 insertions(+), 14 deletions(-)
> > > >
> > > > diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> > > > index ccca8b5..110d8a5 100644
> > > > --- a/ndctl/lib/libndctl.c
> > > > +++ b/ndctl/lib/libndctl.c
> > > > @@ -4593,7 +4593,6 @@ NDCTL_EXPORT int
> > > > ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> > > > const char *bdev = NULL;
> > > > int fd, active = 0;
> > > > char path[50];
> > > > - unsigned long long size =
> > > > ndctl_namespace_get_size(ndns);
> > > >
> > > > if (pfn && ndctl_pfn_is_enabled(pfn))
> > > > bdev = ndctl_pfn_get_block_device(pfn);
> > > > @@ -4630,11 +4629,7 @@ NDCTL_EXPORT int
> > > > ndctl_namespace_disable_safe(struct ndctl_namespace *ndns)
> > > > devname);
> > > > return -EBUSY;
> > > > } else {
> > > > - if (size == 0)
> > > > - /* No disable necessary due to no
> > > > capacity allocated */
> > > > - return 1;
> > > > - else
> > > > -
> > > > ndctl_namespace_disable_invalidate(ndns);
> > > > + ndctl_namespace_disable_invalidate(ndns);
> > > > }
> > > >
> > > > return 0;
> > > > diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> > > > index 257b58c..722f13a 100644
> > > > --- a/ndctl/namespace.c
> > > > +++ b/ndctl/namespace.c
> > > > @@ -1054,9 +1054,6 @@ static int zero_info_block(struct
> > > > ndctl_namespace *ndns)
> > > > void *buf = NULL, *read_buf = NULL;
> > > > char path[50];
> > > >
> > > > - if (ndctl_namespace_get_size(ndns) == 0)
> > > > - return 1;
> > > > -
> > > > ndctl_namespace_set_raw_mode(ndns, 1);
> > > > rc = ndctl_namespace_enable(ndns);
> > > > if (rc < 0) {
> > > > @@ -1130,7 +1127,7 @@ static int namespace_prep_reconfig(struct
> > > > ndctl_region *region,
> > > > }
> > > >
> > > > rc = ndctl_namespace_disable_safe(ndns);
> > > > - if (rc < 0)
> > > > + if (rc)
> > > > return rc;
> > > >
> > > > ndctl_namespace_set_enforce_mode(ndns,
> > > > NDCTL_NS_MODE_RAW);
> > > > @@ -1426,7 +1423,7 @@ static int dax_clear_badblocks(struct
> > > > ndctl_dax *dax)
> > > > return -ENXIO;
> > > >
> > > > rc = ndctl_namespace_disable_safe(ndns);
> > > > - if (rc < 0) {
> > > > + if (rc) {
> > > > error("%s: unable to disable namespace: %s\n",
> > > > devname,
> > > > strerror(-rc));
> > > > return rc;
> > > > @@ -1450,7 +1447,7 @@ static int pfn_clear_badblocks(struct
> > > > ndctl_pfn *pfn)
> > > > return -ENXIO;
> > > >
> > > > rc = ndctl_namespace_disable_safe(ndns);
> > > > - if (rc < 0) {
> > > > + if (rc) {
> > > > error("%s: unable to disable namespace: %s\n",
> > > > devname,
> > > > strerror(-rc));
> > > > return rc;
> > > > @@ -1473,7 +1470,7 @@ static int raw_clear_badblocks(struct
> > > > ndctl_namespace *ndns)
> > > > return -ENXIO;
> > > >
> > > > rc = ndctl_namespace_disable_safe(ndns);
> > > > - if (rc < 0) {
> > > > + if (rc) {
> > > > error("%s: unable to disable namespace: %s\n",
> > > > devname,
> > > > strerror(-rc));
> > > > return rc;
> > > > diff --git a/ndctl/region.c b/ndctl/region.c
> > > > index e499546..33828b0 100644
> > > > --- a/ndctl/region.c
> > > > +++ b/ndctl/region.c
> > > > @@ -71,7 +71,7 @@ static int region_action(struct ndctl_region
> > > > *region, enum device_action mode)
> > > > case ACTION_DISABLE:
> > > > ndctl_namespace_foreach(region, ndns) {
> > > > rc =
> > > > ndctl_namespace_disable_safe(ndns);
> > > > - if (rc < 0)
> > > > + if (rc)
> > > > return rc;
> > > > }
> > > > rc = ndctl_region_disable_invalidate(region);
> > > > --
> > > > 2.35.1
> > > >
> > >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-10 18:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220310120531.4942-1-msuchanek@suse.de>
2022-03-10 12:17 ` Delivery by get send-email to mailing list fails Michal Suchánek
2022-03-10 12:54 ` Delivery by git " Michal Suchánek
2022-03-10 13:29 ` Michal Suchánek
2022-03-10 18:47 ` Verma, Vishal L
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox