* [Ocfs2-devel] [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table
@ 2013-10-22 22:30 Joe Perches
2013-10-22 22:31 ` [Ocfs2-devel] [PATCH 17/24] ocfs2: " Joe Perches
2013-10-22 23:53 ` [Ocfs2-devel] [PATCH 00/24] treewide: " David Daney
0 siblings, 2 replies; 5+ messages in thread
From: Joe Perches @ 2013-10-22 22:30 UTC (permalink / raw)
To: linux-arm-kernel
Joe Perches (24):
arm: Convert use of typedef ctl_table to struct ctl_table
ia64: Convert use of typedef ctl_table to struct ctl_table
s390: Convert use of typedef ctl_table to struct ctl_table
tile: Convert use of typedef ctl_table to struct ctl_table
cdrom: Convert use of typedef ctl_table to struct ctl_table
random: Convert use of typedef ctl_table to struct ctl_table
infiniband: Convert use of typedef ctl_table to struct ctl_table
md: Convert use of typedef ctl_table to struct ctl_table
parport: Convert use of typedef ctl_table to struct ctl_table
scsi: Convert use of typedef ctl_table to struct ctl_table
coda: Convert use of typedef ctl_table to struct ctl_table
fscache: Convert use of typedef ctl_table to struct ctl_table
lockd: Convert use of typedef ctl_table to struct ctl_table
nfs: Convert use of typedef ctl_table to struct ctl_table
inotify: Convert use of typedef ctl_table to struct ctl_table
ntfs: Convert use of typedef ctl_table to struct ctl_table
ocfs2: Convert use of typedef ctl_table to struct ctl_table
proc: Convert use of typedef ctl_table to struct ctl_table
fs: Convert use of typedef ctl_table to struct ctl_table
key: Convert use of typedef ctl_table to struct ctl_table
ipc: Convert use of typedef ctl_table to struct ctl_table
kernel: Convert use of typedef ctl_table to struct ctl_table
mm: Convert use of typedef ctl_table to struct ctl_table
security:keys: Convert use of typedef ctl_table to struct ctl_table
arch/arm/kernel/isa.c | 6 ++---
arch/ia64/kernel/crash.c | 4 +--
arch/ia64/kernel/perfmon.c | 6 ++---
arch/s390/appldata/appldata_base.c | 10 ++++----
arch/s390/kernel/debug.c | 2 +-
arch/s390/mm/cmm.c | 8 +++---
arch/tile/kernel/proc.c | 4 +--
drivers/cdrom/cdrom.c | 10 ++++----
drivers/char/random.c | 4 +--
drivers/infiniband/core/ucma.c | 2 +-
drivers/md/md.c | 6 ++---
drivers/parport/procfs.c | 52 ++++++++++++++++++--------------------
drivers/scsi/scsi_sysctl.c | 6 ++---
fs/coda/sysctl.c | 4 +--
fs/dcache.c | 2 +-
fs/drop_caches.c | 2 +-
fs/eventpoll.c | 2 +-
fs/file_table.c | 4 +--
fs/fscache/main.c | 4 +--
fs/inode.c | 2 +-
fs/lockd/svc.c | 6 ++---
fs/nfs/nfs4sysctl.c | 6 ++---
fs/nfs/sysctl.c | 6 ++---
fs/notify/inotify/inotify_user.c | 2 +-
fs/ntfs/sysctl.c | 4 +--
fs/ocfs2/stackglue.c | 8 +++---
fs/proc/proc_sysctl.c | 2 +-
include/linux/key.h | 2 +-
ipc/ipc_sysctl.c | 14 +++++-----
ipc/mq_sysctl.c | 10 ++++----
kernel/sysctl.c | 2 +-
kernel/utsname_sysctl.c | 6 ++---
mm/page-writeback.c | 2 +-
mm/page_alloc.c | 12 ++++-----
security/keys/sysctl.c | 2 +-
35 files changed, 111 insertions(+), 113 deletions(-)
--
1.8.1.2.459.gbcd45b4.dirty
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH 17/24] ocfs2: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 22:30 [Ocfs2-devel] [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
@ 2013-10-22 22:31 ` Joe Perches
2013-11-07 11:06 ` Joel Becker
2013-10-22 23:53 ` [Ocfs2-devel] [PATCH 00/24] treewide: " David Daney
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-10-22 22:31 UTC (permalink / raw)
To: linux-kernel; +Cc: Mark Fasheh, Joel Becker, ocfs2-devel
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches <joe@perches.com>
---
fs/ocfs2/stackglue.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
index 39abf89..cb7ec0b 100644
--- a/fs/ocfs2/stackglue.c
+++ b/fs/ocfs2/stackglue.c
@@ -643,7 +643,7 @@ error:
#define FS_OCFS2_NM 1
-static ctl_table ocfs2_nm_table[] = {
+static struct ctl_table ocfs2_nm_table[] = {
{
.procname = "hb_ctl_path",
.data = ocfs2_hb_ctl_path,
@@ -654,7 +654,7 @@ static ctl_table ocfs2_nm_table[] = {
{ }
};
-static ctl_table ocfs2_mod_table[] = {
+static struct ctl_table ocfs2_mod_table[] = {
{
.procname = "nm",
.data = NULL,
@@ -665,7 +665,7 @@ static ctl_table ocfs2_mod_table[] = {
{ }
};
-static ctl_table ocfs2_kern_table[] = {
+static struct ctl_table ocfs2_kern_table[] = {
{
.procname = "ocfs2",
.data = NULL,
@@ -676,7 +676,7 @@ static ctl_table ocfs2_kern_table[] = {
{ }
};
-static ctl_table ocfs2_root_table[] = {
+static struct ctl_table ocfs2_root_table[] = {
{
.procname = "fs",
.data = NULL,
--
1.8.1.2.459.gbcd45b4.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 22:30 [Ocfs2-devel] [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-10-22 22:31 ` [Ocfs2-devel] [PATCH 17/24] ocfs2: " Joe Perches
@ 2013-10-22 23:53 ` David Daney
2013-10-22 23:58 ` Joe Perches
1 sibling, 1 reply; 5+ messages in thread
From: David Daney @ 2013-10-22 23:53 UTC (permalink / raw)
To: linux-arm-kernel
On 10/22/2013 03:29 PM, Joe Perches wrote:
> Joe Perches (24):
> arm: Convert use of typedef ctl_table to struct ctl_table
> ia64: Convert use of typedef ctl_table to struct ctl_table
> s390: Convert use of typedef ctl_table to struct ctl_table
> tile: Convert use of typedef ctl_table to struct ctl_table
> cdrom: Convert use of typedef ctl_table to struct ctl_table
> random: Convert use of typedef ctl_table to struct ctl_table
> infiniband: Convert use of typedef ctl_table to struct ctl_table
> md: Convert use of typedef ctl_table to struct ctl_table
> parport: Convert use of typedef ctl_table to struct ctl_table
> scsi: Convert use of typedef ctl_table to struct ctl_table
> coda: Convert use of typedef ctl_table to struct ctl_table
> fscache: Convert use of typedef ctl_table to struct ctl_table
> lockd: Convert use of typedef ctl_table to struct ctl_table
> nfs: Convert use of typedef ctl_table to struct ctl_table
> inotify: Convert use of typedef ctl_table to struct ctl_table
> ntfs: Convert use of typedef ctl_table to struct ctl_table
> ocfs2: Convert use of typedef ctl_table to struct ctl_table
> proc: Convert use of typedef ctl_table to struct ctl_table
> fs: Convert use of typedef ctl_table to struct ctl_table
> key: Convert use of typedef ctl_table to struct ctl_table
> ipc: Convert use of typedef ctl_table to struct ctl_table
> kernel: Convert use of typedef ctl_table to struct ctl_table
> mm: Convert use of typedef ctl_table to struct ctl_table
> security:keys: Convert use of typedef ctl_table to struct ctl_table
After all this work, why not go ahead and remove the typedef? That way
people won't add more users of this abomination.
David Daney
>
> arch/arm/kernel/isa.c | 6 ++---
> arch/ia64/kernel/crash.c | 4 +--
> arch/ia64/kernel/perfmon.c | 6 ++---
> arch/s390/appldata/appldata_base.c | 10 ++++----
> arch/s390/kernel/debug.c | 2 +-
> arch/s390/mm/cmm.c | 8 +++---
> arch/tile/kernel/proc.c | 4 +--
> drivers/cdrom/cdrom.c | 10 ++++----
> drivers/char/random.c | 4 +--
> drivers/infiniband/core/ucma.c | 2 +-
> drivers/md/md.c | 6 ++---
> drivers/parport/procfs.c | 52 ++++++++++++++++++--------------------
> drivers/scsi/scsi_sysctl.c | 6 ++---
> fs/coda/sysctl.c | 4 +--
> fs/dcache.c | 2 +-
> fs/drop_caches.c | 2 +-
> fs/eventpoll.c | 2 +-
> fs/file_table.c | 4 +--
> fs/fscache/main.c | 4 +--
> fs/inode.c | 2 +-
> fs/lockd/svc.c | 6 ++---
> fs/nfs/nfs4sysctl.c | 6 ++---
> fs/nfs/sysctl.c | 6 ++---
> fs/notify/inotify/inotify_user.c | 2 +-
> fs/ntfs/sysctl.c | 4 +--
> fs/ocfs2/stackglue.c | 8 +++---
> fs/proc/proc_sysctl.c | 2 +-
> include/linux/key.h | 2 +-
> ipc/ipc_sysctl.c | 14 +++++-----
> ipc/mq_sysctl.c | 10 ++++----
> kernel/sysctl.c | 2 +-
> kernel/utsname_sysctl.c | 6 ++---
> mm/page-writeback.c | 2 +-
> mm/page_alloc.c | 12 ++++-----
> security/keys/sysctl.c | 2 +-
> 35 files changed, 111 insertions(+), 113 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 23:53 ` [Ocfs2-devel] [PATCH 00/24] treewide: " David Daney
@ 2013-10-22 23:58 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2013-10-22 23:58 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2013-10-22 at 16:53 -0700, David Daney wrote:
> After all this work, why not go ahead and remove the typedef? That way
> people won't add more users of this abomination.
Hi David.
The typedef can't be removed until all the uses are gone.
I've sent this before as a single large patch as well as
individual patches.
treewide: https://lkml.org/lkml/2013/7/22/600
RemoveTypedef: https://lkml.org/lkml/2013/7/22/603
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH 17/24] ocfs2: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 22:31 ` [Ocfs2-devel] [PATCH 17/24] ocfs2: " Joe Perches
@ 2013-11-07 11:06 ` Joel Becker
0 siblings, 0 replies; 5+ messages in thread
From: Joel Becker @ 2013-11-07 11:06 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Mark Fasheh, ocfs2-devel
On Tue, Oct 22, 2013 at 03:30:00PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
> ---
> fs/ocfs2/stackglue.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index 39abf89..cb7ec0b 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -643,7 +643,7 @@ error:
>
> #define FS_OCFS2_NM 1
>
> -static ctl_table ocfs2_nm_table[] = {
> +static struct ctl_table ocfs2_nm_table[] = {
> {
> .procname = "hb_ctl_path",
> .data = ocfs2_hb_ctl_path,
> @@ -654,7 +654,7 @@ static ctl_table ocfs2_nm_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_mod_table[] = {
> +static struct ctl_table ocfs2_mod_table[] = {
> {
> .procname = "nm",
> .data = NULL,
> @@ -665,7 +665,7 @@ static ctl_table ocfs2_mod_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_kern_table[] = {
> +static struct ctl_table ocfs2_kern_table[] = {
> {
> .procname = "ocfs2",
> .data = NULL,
> @@ -676,7 +676,7 @@ static ctl_table ocfs2_kern_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_root_table[] = {
> +static struct ctl_table ocfs2_root_table[] = {
> {
> .procname = "fs",
> .data = NULL,
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
http://www.jlbec.org/
jlbec at evilplan.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-07 11:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 22:30 [Ocfs2-devel] [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-10-22 22:31 ` [Ocfs2-devel] [PATCH 17/24] ocfs2: " Joe Perches
2013-11-07 11:06 ` Joel Becker
2013-10-22 23:53 ` [Ocfs2-devel] [PATCH 00/24] treewide: " David Daney
2013-10-22 23:58 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox