0 day kernel build service
 help / color / mirror / Atom feed
* drivers/net/ethernet/airoha/airoha_eth.c:2139 airoha_qdma_set_chan_tx_sched() warn: subtract is higher precedence than shift
@ 2026-07-01 21:55 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-07-01 21:55 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Lorenzo Bianconi <lorenzo@kernel.org>
CC: Jakub Kicinski <kuba@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   665159e246749578d4e4bfe106ee3b74edcdab18
commit: 7600fb3b41dd6ab65ed61169df1b6099044edf97 net: airoha: Rely __field_prep for non-constant masks
date:   4 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 4 months ago
config: sh-randconfig-r072-20260702 (https://download.01.org/0day-ci/archive/20260702/202607020543.QhFmLp46-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.2.0
smatch: v0.5.0-9185-gbcc58b9c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 7600fb3b41dd ("net: airoha: Rely __field_prep for non-constant masks")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202607020543.QhFmLp46-lkp@intel.com/

New smatch warnings:
drivers/net/ethernet/airoha/airoha_eth.c:2139 airoha_qdma_set_chan_tx_sched() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:2139 airoha_qdma_set_chan_tx_sched() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:2139 airoha_qdma_set_chan_tx_sched() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:2139 airoha_qdma_set_chan_tx_sched() warn: subtract is higher precedence than shift

Old smatch warnings:
drivers/net/ethernet/airoha/airoha_eth.c:1727 airhoha_set_gdm2_loopback() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1727 airhoha_set_gdm2_loopback() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1727 airhoha_set_gdm2_loopback() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1727 airhoha_set_gdm2_loopback() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1782 airoha_dev_init() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1782 airoha_dev_init() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1782 airoha_dev_init() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_eth.c:1782 airoha_dev_init() warn: subtract is higher precedence than shift

vim +2139 drivers/net/ethernet/airoha/airoha_eth.c

23020f04932701d drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2024-07-12  2110  
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2111  static int airoha_qdma_set_chan_tx_sched(struct airoha_gdm_port *port,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2112  					 int channel, enum tx_sched_mode mode,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2113  					 const u16 *weights, u8 n_weights)
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2114  {
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2115  	int i;
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2116  
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2117  	for (i = 0; i < AIROHA_NUM_TX_RING; i++)
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2118  		airoha_qdma_clear(port->qdma, REG_QUEUE_CLOSE_CFG(channel),
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2119  				  TXQ_DISABLE_CHAN_QUEUE_MASK(channel, i));
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2120  
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2121  	for (i = 0; i < n_weights; i++) {
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2122  		u32 status;
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2123  		int err;
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2124  
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2125  		airoha_qdma_wr(port->qdma, REG_TXWRR_WEIGHT_CFG,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2126  			       TWRR_RW_CMD_MASK |
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2127  			       FIELD_PREP(TWRR_CHAN_IDX_MASK, channel) |
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2128  			       FIELD_PREP(TWRR_QUEUE_IDX_MASK, i) |
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2129  			       FIELD_PREP(TWRR_VALUE_MASK, weights[i]));
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2130  		err = read_poll_timeout(airoha_qdma_rr, status,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2131  					status & TWRR_RW_CMD_DONE,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2132  					USEC_PER_MSEC, 10 * USEC_PER_MSEC,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2133  					true, port->qdma,
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2134  					REG_TXWRR_WEIGHT_CFG);
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2135  		if (err)
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2136  			return err;
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2137  	}
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2138  
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03 @2139  	airoha_qdma_rmw(port->qdma, REG_CHAN_QOS_MODE(channel >> 3),
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2140  			CHAN_QOS_MODE_MASK(channel),
7600fb3b41dd6ab drivers/net/ethernet/airoha/airoha_eth.c   Lorenzo Bianconi 2026-03-04  2141  			__field_prep(CHAN_QOS_MODE_MASK(channel), mode));
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2142  
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2143  	return 0;
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2144  }
20bf7d07c956e5c drivers/net/ethernet/mediatek/airoha_eth.c Lorenzo Bianconi 2025-01-03  2145  

:::::: The code at line 2139 was first introduced by commit
:::::: 20bf7d07c956e5c7a22d3076c599cbb7a6054917 net: airoha: Add sched ETS offload support

:::::: TO: Lorenzo Bianconi <lorenzo@kernel.org>
:::::: CC: Paolo Abeni <pabeni@redhat.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-01 21:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01 21:55 drivers/net/ethernet/airoha/airoha_eth.c:2139 airoha_qdma_set_chan_tx_sched() warn: subtract is higher precedence than shift kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox