Re: [PATCH] vfio: Use file-based reference counting for KVM

Re: [PATCH] vfio: Use file-based reference counting for KVM

[kernel test robot]

:::::: 
:::::: Manual check reason: "linux-review patch is more than 7 days old, verify it wasn't already superseded"
:::::: 

BCC: lkp@intel.com
CC: llvm@lists.linux.dev
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260812-vfio-v1-1-5cfe0b1fa4e7@linux.ibm.com>
References: <20260812-vfio-v1-1-5cfe0b1fa4e7@linux.ibm.com>
TO: Steffen Eiden <seiden@linux.ibm.com>
TO: Sean Christopherson <seanjc@google.com>
TO: Paolo Bonzini <pbonzini@redhat.com>
TO: Thomas Gleixner <tglx@kernel.org>
TO: Ingo Molnar <mingo@redhat.com>
TO: Borislav Petkov <bp@alien8.de>
TO: Dave Hansen <dave.hansen@linux.intel.com>
TO: x86@kernel.org
TO: "H. Peter Anvin" <hpa@zytor.com>
TO: Tony Krowiak <akrowiak@linux.ibm.com>
TO: Halil Pasic <pasic@linux.ibm.com>
TO: Jason Herne <jjherne@linux.ibm.com>
TO: Harald Freudenberger <freude@linux.ibm.com>
TO: Holger Dengler <dengler@linux.ibm.com>
TO: Heiko Carstens <hca@linux.ibm.com>
TO: Vasily Gorbik <gor@linux.ibm.com>
TO: Alexander Gordeev <agordeev@linux.ibm.com>
TO: Christian Borntraeger <borntraeger@linux.ibm.com>
TO: Sven Schnelle <svens@linux.ibm.com>
TO: Alex Williamson <alex@shazbot.org>
TO: Matthew Rosato <mjrosato@linux.ibm.com>
TO: Farhan Ali <alifm@linux.ibm.com>
TO: Eric Farman <farman@linux.ibm.com>
TO: Claudio Imbrenda <imbrenda@linux.ibm.com>
TO: Janosch Frank <frankja@linux.ibm.com>
CC: kvm@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-s390@vger.kernel.org
CC: Steffen Eiden <seiden@linux.ibm.com>
CC: Jason Gunthorpe <jgg@ziepe.ca>

Hi Steffen,

kernel test robot noticed the following build errors:

[auto build test ERROR on 5e6de6a2b522f659defacb1551d0465ba6ce13cf]

url:    https://github.com/intel-lab-lkp/linux/commits/Steffen-Eiden/vfio-Use-file-based-reference-counting-for-KVM/20260812-205530
base:   5e6de6a2b522f659defacb1551d0465ba6ce13cf
patch link:    https://lore.kernel.org/r/20260812-vfio-v1-1-5cfe0b1fa4e7%40linux.ibm.com
patch subject: [PATCH] vfio: Use file-based reference counting for KVM
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: hexagon-randconfig-001-20260823 (https://download.01.org/0day-ci/archive/20260824/202608240204.0qmo4vRs-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 935bfc708590c60147a79c7df145bb6e68b1d388)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260824/202608240204.0qmo4vRs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202608240204.0qmo4vRs-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/vfio/vfio_main.c:1554:29: error: incompatible pointer types passing 'struct file *' to parameter of type 'struct kvm *' [-Wincompatible-pointer-types]
    1554 |                 vfio_group_set_kvm(group, kvm);
         |                                           ^~~
   drivers/vfio/vfio.h:168:77: note: passing argument to parameter 'kvm' here
     168 | static inline void vfio_group_set_kvm(struct vfio_group *group, struct kvm *kvm)
         |                                                                             ^
   1 error generated.


vim +1554 drivers/vfio/vfio_main.c

34aeeecdb3357f9 Yi Liu        2023-07-18  1539  
b1a59be8a2b64d0 Yi Liu        2023-07-18  1540  /**
b1a59be8a2b64d0 Yi Liu        2023-07-18  1541   * vfio_file_set_kvm - Link a kvm with VFIO drivers
2a7387af7a9f2fa Steffen Eiden 2026-08-12  1542   * @vfio_file: VFIO group file or VFIO device file
2a7387af7a9f2fa Steffen Eiden 2026-08-12  1543   * @kvm: KVM file to link
b1a59be8a2b64d0 Yi Liu        2023-07-18  1544   *
b1a59be8a2b64d0 Yi Liu        2023-07-18  1545   * When a VFIO device is first opened the KVM will be available in
b1a59be8a2b64d0 Yi Liu        2023-07-18  1546   * device->kvm if one was associated with the file.
b1a59be8a2b64d0 Yi Liu        2023-07-18  1547   */
2a7387af7a9f2fa Steffen Eiden 2026-08-12  1548  void vfio_file_set_kvm(struct file *vfio_file, struct file *kvm)
b1a59be8a2b64d0 Yi Liu        2023-07-18  1549  {
b1a59be8a2b64d0 Yi Liu        2023-07-18  1550  	struct vfio_group *group;
b1a59be8a2b64d0 Yi Liu        2023-07-18  1551  
2a7387af7a9f2fa Steffen Eiden 2026-08-12  1552  	group = vfio_group_from_file(vfio_file);
b1a59be8a2b64d0 Yi Liu        2023-07-18  1553  	if (group)
b1a59be8a2b64d0 Yi Liu        2023-07-18 @1554  		vfio_group_set_kvm(group, kvm);
34aeeecdb3357f9 Yi Liu        2023-07-18  1555  
2a7387af7a9f2fa Steffen Eiden 2026-08-12  1556  	if (vfio_device_from_file(vfio_file))
2a7387af7a9f2fa Steffen Eiden 2026-08-12  1557  		vfio_device_file_set_kvm(vfio_file, kvm);
b1a59be8a2b64d0 Yi Liu        2023-07-18  1558  }
b1a59be8a2b64d0 Yi Liu        2023-07-18  1559  EXPORT_SYMBOL_GPL(vfio_file_set_kvm);
b1a59be8a2b64d0 Yi Liu        2023-07-18  1560  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki