0 day kernel build service
 help / color / mirror / Atom feed
* [frank-w-bpi-r2-4.14:7.2-main 213/213] drivers/tty/serial/8250/8250_mtk.c:437 mtk8250_runtime_suspend() warn: test_and_clear_bit() takes a bit number
@ 2026-09-09 19:05 kernel test robot
  2026-09-09 19:48 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-09-09 19:05 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Frank Wunderlich <frank-w@public-files.de>

tree:   https://github.com/frank-w/BPI-R2-4.14 7.2-main
head:   e2b8c6a7a01daa29f0109ecfd5d0fa93e27da8bf
commit: 6f53f04819bff1609acb1655c95238965736452b [213/213] serial: 8250_mtk: track busclk state to avoid bus error
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
config: loongarch-randconfig-r073-20260910 (https://download.01.org/0day-ci/archive/20260910/202609100256.0onKHOy1-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 16.1.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609100256.0onKHOy1-lkp@intel.com/

New smatch warnings:
drivers/tty/serial/8250/8250_mtk.c:437 mtk8250_runtime_suspend() warn: test_and_clear_bit() takes a bit number
drivers/tty/serial/8250/8250_mtk.c:454 mtk8250_runtime_resume() warn: test_and_set_bit() takes a bit number

Old smatch warnings:
arch/loongarch/include/asm/atomic.h:51 arch_atomic_fetch_add_unless() warn: inconsistent indenting

vim +437 drivers/tty/serial/8250/8250_mtk.c

b4756f4f0d773c Matthias Brugger 2014-09-09  431  
9db669f14fd829 Arnd Bergmann    2016-02-08  432  static int __maybe_unused mtk8250_runtime_suspend(struct device *dev)
68e5fc4a255a7f Sascha Hauer     2015-04-27  433  {
68e5fc4a255a7f Sascha Hauer     2015-04-27  434  	struct mtk8250_data *data = dev_get_drvdata(dev);
e32a83c70cf987 Changqi Hu       2020-02-26  435  	struct uart_8250_port *up = serial8250_get_port(data->line);
68e5fc4a255a7f Sascha Hauer     2015-04-27  436  
6f53f04819bff1 Daniel Golle     2023-09-11 @437  	if (!test_and_clear_bit(MTK_UART_STATE_BIT_BUSCLK_EN, &data->state))
6f53f04819bff1 Daniel Golle     2023-09-11  438  		return 0;
6f53f04819bff1 Daniel Golle     2023-09-11  439  
e32a83c70cf987 Changqi Hu       2020-02-26  440  	/* wait until UART in idle status */
e32a83c70cf987 Changqi Hu       2020-02-26  441  	while
e32a83c70cf987 Changqi Hu       2020-02-26  442  		(serial_in(up, MTK_UART_DEBUG0));
e32a83c70cf987 Changqi Hu       2020-02-26  443  
d518314a1fa4e9 Daniel Golle     2025-09-16  444  	clk_disable_unprepare(data->uart_clk);
c1c325d703d347 Sascha Hauer     2015-04-27  445  	clk_disable_unprepare(data->bus_clk);
68e5fc4a255a7f Sascha Hauer     2015-04-27  446  
68e5fc4a255a7f Sascha Hauer     2015-04-27  447  	return 0;
68e5fc4a255a7f Sascha Hauer     2015-04-27  448  }
68e5fc4a255a7f Sascha Hauer     2015-04-27  449  
9db669f14fd829 Arnd Bergmann    2016-02-08  450  static int __maybe_unused mtk8250_runtime_resume(struct device *dev)
68e5fc4a255a7f Sascha Hauer     2015-04-27  451  {
68e5fc4a255a7f Sascha Hauer     2015-04-27  452  	struct mtk8250_data *data = dev_get_drvdata(dev);
68e5fc4a255a7f Sascha Hauer     2015-04-27  453  
6f53f04819bff1 Daniel Golle     2023-09-11 @454  	if (test_and_set_bit(MTK_UART_STATE_BIT_BUSCLK_EN, &data->state))
6f53f04819bff1 Daniel Golle     2023-09-11  455  		return 0;
6f53f04819bff1 Daniel Golle     2023-09-11  456  
b6c7ff2693ddc2 Chen-Yu Tsai     2023-06-06  457  	clk_prepare_enable(data->bus_clk);
d518314a1fa4e9 Daniel Golle     2025-09-16  458  	clk_prepare_enable(data->uart_clk);
c1c325d703d347 Sascha Hauer     2015-04-27  459  
68e5fc4a255a7f Sascha Hauer     2015-04-27  460  	return 0;
68e5fc4a255a7f Sascha Hauer     2015-04-27  461  }
68e5fc4a255a7f Sascha Hauer     2015-04-27  462  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-09 19:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-09 19:05 [frank-w-bpi-r2-4.14:7.2-main 213/213] drivers/tty/serial/8250/8250_mtk.c:437 mtk8250_runtime_suspend() warn: test_and_clear_bit() takes a bit number kernel test robot
2026-09-09 19:48 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox