Compiler errors.

Compiler errors.

[Marko Saukko]

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

Hi,

with the latest oFono git version I'm getting the following compiler
errors when using gcc (Ubuntu 4.3.3-5ubuntu4) 4.3.3.

----

gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../src
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -g -O2 -Werror
-Wextra -Wno-unused-parameter -Wno-missing-field-initializers
-Wdeclaration-after-statement -Wmissing-declarations -Wredundant-decls
-Wcast-align -MT smsutil.o -MD -MP -MF .deps/smsutil.Tpo -c -o smsutil.o
`test -f '../src/smsutil.c' || echo './'`../src/smsutil.c
cc1: warnings being treated as errors
../src/smsutil.c: In function ‘sms_extract_common’:
../src/smsutil.c:1442: error: ‘dcs’ may be used uninitialized in this
function
../src/smsutil.c:1441: error: ‘udhi’ may be used uninitialized in this
function
../src/smsutil.c:1440: error: ‘max’ may be used uninitialized in this
function
../src/smsutil.c:1439: error: ‘udl’ may be used uninitialized in this
function
../src/smsutil.c: In function ‘extract_app_port_common’:
../src/smsutil.c:1756: error: ‘is_addr_8bit’ may be used uninitialized
in this function
../src/smsutil.c: In function ‘sms_extract_concatenation’:
../src/smsutil.c:1843: error: ‘seq’ may be used uninitialized in this
function
../src/smsutil.c:1843: error: ‘max’ may be used uninitialized in this
function
../src/smsutil.c:1842: error: ‘rn’ may be used uninitialized in this
function
../src/smsutil.c: In function ‘cbs_decode_text’:
../src/smsutil.c:2706: error: ‘iso639’ may be used uninitialized in this
function
../src/smsutil.c:2704: error: ‘charset’ may be used uninitialized in
this function
make[2]: *** [smsutil.o] Error 1
make[2]: Leaving directory `/home/muk/software/ofono/ofono/unit'

----

Regards,
Marko

Re: Compiler errors.

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Hi Marko,

> with the latest oFono git version I'm getting the following compiler
> errors when using gcc (Ubuntu 4.3.3-5ubuntu4) 4.3.3.
> 
> ----
> 
> gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../src
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -g -O2 -Werror
> -Wextra -Wno-unused-parameter -Wno-missing-field-initializers
> -Wdeclaration-after-statement -Wmissing-declarations -Wredundant-decls
> -Wcast-align -MT smsutil.o -MD -MP -MF .deps/smsutil.Tpo -c -o smsutil.o
> `test -f '../src/smsutil.c' || echo './'`../src/smsutil.c
> cc1: warnings being treated as errors
> ../src/smsutil.c: In function ‘sms_extract_common’:
> ../src/smsutil.c:1442: error: ‘dcs’ may be used uninitialized in this
> function
> ../src/smsutil.c:1441: error: ‘udhi’ may be used uninitialized in this
> function

I didn't see them when building the release, but some distro compilers
are a different.

Denis, care to fix these please.

Regards

Marcel

Re: Compiler errors.

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

Hi Marko,

> with the latest oFono git version I'm getting the following compiler
> errors when using gcc (Ubuntu 4.3.3-5ubuntu4) 4.3.3.

so Denis and I fixed all of these now.

Regards

Marcel