From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] Extended modem.conf
Date: Tue, 27 Oct 2009 20:20:05 +0900 [thread overview]
Message-ID: <1256642405.5768.14.camel@localhost.localdomain> (raw)
In-Reply-To: <632f5f310910270242g5d1f594bse3a9085e542d27a@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
Hi Ryan,
> Allright. This is the one to consider. I used the checkpatch.pl, which
> informed me of my wayward ways.
>
> I read from previous mails that the signed-off is not needed, is that
> still in effect?
yes, that is still true. We are not using Signed-off-by statements.
> ---
> gatchat/gattty.c | 16 +++++++-------
> plugins/atgen.c | 48 ++++++++++++++++++++++++++++++++++++++--
> plugins/modemconf.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 111 insertions(+), 12 deletions(-)
please split this into two patches. One that modifies gatchat/ and then
the rest in a second patch.
Regards
Marcel
next prev parent reply other threads:[~2009-10-27 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 9:42 [PATCH 1/1] Extended modem.conf Ryan Raasch
2009-10-27 11:20 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-26 11:02 Ryan Raasch
2009-10-26 13:33 ` Ryan Raasch
2009-10-26 17:46 ` Denis Kenzior
2009-10-27 4:38 ` Andres Salomon
2009-10-27 8:45 ` Ryan Raasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256642405.5768.14.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox