From: Andres Salomon <dilinger@collabora.co.uk>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] Extended modem.conf
Date: Tue, 27 Oct 2009 06:38:45 +0200 [thread overview]
Message-ID: <20091027063845.7199b228@mycelium.queued.net> (raw)
In-Reply-To: <200910261246.27843.denkenz@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Mon, 26 Oct 2009 12:46:26 -0500
Denis Kenzior <denkenz@gmail.com> wrote:
> Hi Ryan,
>
> > Hello,
> >
> > This a patch for allowing the addition of more options to the
> > generic atgen driver. Comments :) ?
>
> Before I look further into this, please re-submit the patch and
> follow the oFono code style conventions. oFono uses kernel coding
> style and no maintainer will even look at patches that do not follow
> this convention.
Also, it would be helpful if the patch was inline so that people could
easily comment on various pieces of it in their replies.
next prev parent reply other threads:[~2009-10-27 4:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 11:02 [PATCH 1/1] Extended modem.conf Ryan Raasch
2009-10-26 13:33 ` Ryan Raasch
2009-10-26 17:46 ` Denis Kenzior
2009-10-27 4:38 ` Andres Salomon [this message]
2009-10-27 8:45 ` Ryan Raasch
-- strict thread matches above, loose matches on Subject: below --
2009-10-27 9:42 Ryan Raasch
2009-10-27 11:20 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027063845.7199b228@mycelium.queued.net \
--to=dilinger@collabora.co.uk \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox