From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: RE: Patch on unsupported AT command
Date: Tue, 17 Nov 2009 11:40:46 +0100 [thread overview]
Message-ID: <1258454446.2003.6.camel@violet> (raw)
In-Reply-To: <38D9F46DFF92C54980D2F2C1E8EE313001B4C0170D@pdsmsx503.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
Hi Yang,
> >> > > I think this might need a GAtChat quirk function where we can add extra
> >> > > terminator responses that will be recognized. And maybe even translated
> >> > > into something meaningful.
> >> >
> >> > Originally I had the terminators freely definable on the GAtChat + some
> >> > hardcoded ones, but abandoned that approach since it didn't seem useful.
> >> > Perhaps this needs to be resurrected.
> >> >
> >> > > Denis, or do you want this quirked in every plugin or modem driver?
> >> >
> >> > I do prefer non-standard terminators to be setup in the plugin/driver.
> >>
> >> I meant adding something like g_at_chat_add_terminator() or so.
> >
> >Yes, that is what I meant as well.
>
> Attached is the patch to support plugin specific terminator, and it supports Huawei's special one "COMMAND NOT SUPPORT".
you need to split this into a GAtChat specific patch and oFono plugin
patch.
Regards
Marcel
next prev parent reply other threads:[~2009-11-17 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 7:11 Patch on unsupported AT command Gu, Yang
2009-11-13 11:18 ` Marcel Holtmann
2009-11-13 16:38 ` Denis Kenzior
2009-11-13 16:58 ` Marcel Holtmann
2009-11-13 17:05 ` Denis Kenzior
2009-11-17 9:38 ` Gu, Yang
2009-11-17 10:40 ` Marcel Holtmann [this message]
2009-11-17 16:27 ` Gu, Yang
2009-11-17 17:56 ` Denis Kenzior
2009-11-17 20:35 ` Marcel Holtmann
2009-11-20 9:02 ` Gu, Yang
2009-11-20 13:30 ` Marcel Holtmann
2009-11-21 5:54 ` Gu, Yang
2009-11-21 10:41 ` Marcel Holtmann
2009-11-23 2:41 ` Gu, Yang
2009-11-23 6:21 ` Marcel Holtmann
2009-11-23 10:54 ` Denis Kenzior
2009-11-23 16:08 ` Marcel Holtmann
2009-11-24 16:01 ` Gu, Yang
2009-11-24 17:07 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258454446.2003.6.camel@violet \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox