Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: Patch on unsupported AT command
Date: Tue, 17 Nov 2009 21:35:34 +0100	[thread overview]
Message-ID: <1258490134.2003.34.camel@violet> (raw)
In-Reply-To: <200911171156.15968.denkenz@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hi Denis,

> >+	g_at_chat_add_terminator(chat, "+EXT ERROR:", 11, FALSE);
> >+	g_at_chat_add_terminator(chat, "+CME ERROR:", 11, FALSE);
> >+	g_at_chat_add_terminator(chat, "+CMS ERROR:", 11, FALSE);
> >+	g_at_chat_add_terminator(chat, "NO ANSWER", -1, FALSE);
> >+	g_at_chat_add_terminator(chat, "CONNECT", -1, TRUE);
> >+	g_at_chat_add_terminator(chat, "NO CARRIER", -1, FALSE);
> >+	g_at_chat_add_terminator(chat, "BUSY", -1, FALSE);
> >+	g_at_chat_add_terminator(chat, "NO DIALTONE", -1, FALSE);
> >+	g_at_chat_add_terminator(chat, "ERROR", -1, FALSE);
> >+	g_at_chat_add_terminator(chat, "OK", -1, TRUE);
> 
> I really don't like this.  Lets keep the non-standard terminators in a 
> separate list.  I don't want the vast majority of the drivers incurring the 
> cost of multiple g_new/g_frees.

I have to agree on this. We should keep the penalty for well behaving
cards as small as possible.

Regards

Marcel



  reply	other threads:[~2009-11-17 20:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  7:11 Patch on unsupported AT command Gu, Yang
2009-11-13 11:18 ` Marcel Holtmann
2009-11-13 16:38   ` Denis Kenzior
2009-11-13 16:58     ` Marcel Holtmann
2009-11-13 17:05       ` Denis Kenzior
2009-11-17  9:38         ` Gu, Yang
2009-11-17 10:40           ` Marcel Holtmann
2009-11-17 16:27             ` Gu, Yang
2009-11-17 17:56               ` Denis Kenzior
2009-11-17 20:35                 ` Marcel Holtmann [this message]
2009-11-20  9:02                   ` Gu, Yang
2009-11-20 13:30                     ` Marcel Holtmann
2009-11-21  5:54                       ` Gu, Yang
2009-11-21 10:41                         ` Marcel Holtmann
2009-11-23  2:41                           ` Gu, Yang
2009-11-23  6:21                             ` Marcel Holtmann
2009-11-23 10:54                               ` Denis Kenzior
2009-11-23 16:08                                 ` Marcel Holtmann
2009-11-24 16:01                               ` Gu, Yang
2009-11-24 17:07                                 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258490134.2003.34.camel@violet \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox